Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump to core v1.45.0-tm-v0.34.35 and cosmos-sdk v1.27.0-sdk-v0.46.16 #4227

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

rach-id
Copy link
Member

@rach-id rach-id commented Jan 15, 2025

Overview

Bump to latest core and cosmos-sdk to support the new block gRPC endpoints

@rach-id rach-id self-assigned this Jan 15, 2025
@rach-id rach-id requested a review from a team as a code owner January 15, 2025 14:11
@rach-id rach-id requested review from rootulp and cmwaters and removed request for a team January 15, 2025 14:11
@rach-id rach-id added the backport:v3.x PR will be backported automatically to the v3.x branch upon merging label Jan 15, 2025
Copy link
Contributor

coderabbitai bot commented Jan 15, 2025

📝 Walkthrough

Walkthrough

This pull request focuses on updating dependency versions in go.mod files across two different modules. The changes primarily involve version upgrades for key dependencies such as golang.org/x/net, github.com/cosmos/cosmos-sdk, and github.com/tendermint/tendermint. The modifications are consistent across both the main go.mod and the test/interchain/go.mod file, suggesting a coordinated update of library versions to potentially incorporate recent improvements or bug fixes.

Changes

File Changes
go.mod - Updated golang.org/x/net from v0.31.0 to v0.33.0
- Updated github.com/cosmos/cosmos-sdk from v1.26.1-sdk-v0.46.16 to v1.27.0-sdk-v0.46.16
- Updated github.com/tendermint/tendermint from v1.44.2-tm-v0.34.35 to v1.45.0-tm-v0.34.35
test/interchain/go.mod - Updated github.com/stretchr/testify from v1.9.0 to v1.10.0
- Updated golang.org/x/net from v0.28.0 to v0.33.0
- Updated replace statements for github.com/cosmos/cosmos-sdk and github.com/tendermint/tendermint similarly to main go.mod

Possibly related PRs

Suggested labels

backport:v3.x

Suggested reviewers

  • cmwaters
  • evan-forbes
  • ninabarbakadze

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9d906c7 and f0427e4.

⛔ Files ignored due to path filters (2)
  • go.sum is excluded by !**/*.sum
  • test/interchain/go.sum is excluded by !**/*.sum
📒 Files selected for processing (2)
  • go.mod (2 hunks)
  • test/interchain/go.mod (3 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (2)
  • GitHub Check: test / test
  • GitHub Check: Summary
🔇 Additional comments (4)
test/interchain/go.mod (2)

227-231: Version updates align with PR objectives

The updates to cosmos-sdk (v1.27.0) and celestia-core (v1.45.0) match the PR objectives and are consistently applied.


9-9: Verify compatibility with testify v1.10.0

The update to testify v1.10.0 is a minor version bump that could introduce changes affecting tests.

✅ Verification successful

Testify v1.10.0 update is safe to proceed

The update from v1.9.0 to v1.10.0 follows semantic versioning and contains no breaking changes. All test assertions in the codebase use stable patterns that are maintained across versions.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Check for any breaking changes in test assertions
rg -A 2 "assert\.|require\." | grep -v "_test.go"

Length of output: 12295

go.mod (2)

257-260: Core dependency updates look good

The updates to cosmos-sdk (v1.27.0) and celestia-core (v1.45.0) are:

  1. Consistently applied across both go.mod files
  2. Match the PR objectives for supporting new block gRPC endpoints

231-231: Verify compatibility with golang.org/x/net v0.33.0

The update to golang.org/x/net v0.33.0 is applied consistently across both go.mod files.

✅ Verification successful

golang.org/x/net v0.33.0 update is safe

The codebase uses only stable networking primitives that are maintained with backward compatibility. No deprecated API usage or compatibility issues were found.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Check for any deprecated API usage
rg -A 2 "net\..*" | grep -v "_test.go"

Length of output: 26712


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Member

@evan-forbes evan-forbes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we just want to be careful not to create a release until we are confident that we are not delaying consensus with rechecks too much

@rach-id
Copy link
Member Author

rach-id commented Jan 15, 2025

Thanks a lot for the reminder. Will be working on the benchmark next before the release

@rach-id rach-id merged commit 6a9d5f3 into main Jan 15, 2025
28 of 29 checks passed
@rach-id rach-id deleted the bump-to-latest-core-and-cosmos-sk branch January 15, 2025 19:19
mergify bot pushed a commit that referenced this pull request Jan 15, 2025
…sdk-v0.46.16 (#4227)

## Overview

Bump to latest core and cosmos-sdk to support the new block gRPC
endpoints

(cherry picked from commit 6a9d5f3)

# Conflicts:
#	go.mod
rach-id added a commit that referenced this pull request Jan 16, 2025
…sdk-v0.46.16 (backport #4227) (#4231)

## Overview

Bump to latest core and cosmos-sdk to support the new block gRPC
endpoints<hr>This is an automatic backport of pull request #4227 done by
[Mergify](https://mergify.com).

---------

Co-authored-by: CHAMI Rachid <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:v3.x PR will be backported automatically to the v3.x branch upon merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants