Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ledger nano s+ #4146

Merged
merged 2 commits into from
Dec 23, 2024
Merged

fix: ledger nano s+ #4146

merged 2 commits into from
Dec 23, 2024

Conversation

rootulp
Copy link
Collaborator

@rootulp rootulp commented Dec 19, 2024 •
edited
Loading

Closes #4106 by upgrading to cosmos-ledger-go v0.14.0

Testing

I verified that a Ledger Nano X can still submit a PFB on Celestia (see gist). I don't have a Ledger Nano S+ to test with 😞

Update: I tested with a Ledger Nano X before and after this change and I can still sign transactions.

@rootulp rootulp self-assigned this Dec 19, 2024
@rootulp rootulp changed the title fix: ledger nano s plus fix: ledger nano s+ Dec 19, 2024
@rootulp rootulp added warn:blocked item is not currently being worked on but is still blocked and removed warn:blocked item is not currently being worked on but is still blocked labels Dec 19, 2024
@rootulp rootulp marked this pull request as ready for review December 20, 2024 15:39
@rootulp rootulp requested a review from a team as a code owner December 20, 2024 15:39
@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 20, 2024

📝 Walkthrough

Walkthrough

This pull request focuses on updating dependency versions in the go.mod files for the main project and the interchain test module. The primary changes involve upgrading github.com/cosmos/ledger-cosmos-go from v0.13.2 to v0.14.0 and github.com/cosmos/cosmos-sdk from v1.25.1 to v1.26.0. Several other Go dependencies, including various golang.org/x/* packages, have also been updated to their latest versions. The replacement directives have been adjusted to reflect these version changes.

Changes

File Change Summary
go.mod - Updated github.com/cosmos/ledger-cosmos-go to v0.14.0
- Updated github.com/cosmos/cosmos-sdk to v1.26.0-sdk-v0.46.16
- Removed replace directive for github.com/cosmos/ledger-cosmos-go
test/interchain/go.mod - Updated multiple dependencies:
- github.com/cosmos/ledger-cosmos-go to v0.14.0
- golang.org/x/* packages to latest versions
- Updated github.com/cosmos/cosmos-sdk replacement to v1.26.0-sdk-v0.46.16

Assessment against linked issues

Objective Addressed Explanation
Upgrade Ledger support ✅
Fix Ledger Nano S+ compatibility ✅

Possibly related PRs

Suggested reviewers

  • rach-id
  • evan-forbes
  • ninabarbakadze
  • cmwaters
📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 415e870 and d413500.

⛔ Files ignored due to path filters (2)
  • go.sum is excluded by !**/*.sum
  • test/interchain/go.sum is excluded by !**/*.sum
📒 Files selected for processing (2)
  • go.mod (2 hunks)
  • test/interchain/go.mod (3 hunks)
🔇 Additional comments (4)
test/interchain/go.mod (2)

227-227: LGTM: Cosmos SDK replacement is consistent.

The update to cosmos-sdk v1.26.0-sdk-v0.46.16 is consistent with the main module.

48-48: LGTM: Ledger dependency update matches PR objective.

The update to ledger-cosmos-go v0.14.0 aligns with the goal of fixing Ledger Nano S+ support.

Let's verify if this version specifically addresses Ledger Nano S+ support:

go.mod (2)

86-86: LGTM: Ledger dependency update is consistent.

The update to ledger-cosmos-go v0.14.0 matches the interchain test module.

256-256: Verify Ledger Nano S+ compatibility.

While the dependency update aims to fix Ledger Nano S+ support, testing with the actual device is still needed.

Please ensure:

  1. Testing with a Ledger Nano S+ device to confirm the fix
  2. Verification of PFB submission functionality

Would you like me to create a GitHub issue to track the Ledger Nano S+ testing requirement?

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@rootulp rootulp enabled auto-merge (squash) December 20, 2024 16:25
rach-id
rach-id approved these changes Dec 23, 2024
View reviewed changes
Copy link
Member

@rach-id rach-id left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utAck

@rootulp rootulp merged commit 13149fc into celestiaorg:main Dec 23, 2024
29 checks passed
@rootulp rootulp deleted the rp/fix-ledger-nanos-plus branch January 2, 2025 02:40
@rootulp rootulp added the backport:v3.x PR will be backported automatically to the v3.x branch upon merging label Jan 2, 2025
mergify bot pushed a commit that referenced this pull request Jan 2, 2025
@rootulp @mergify
fix: ledger nano s+ (#4146)
b007a7c 
Closes #4106 by
upgrading to cosmos-ledger-go v0.14.0

## Testing

I verified that a Ledger Nano X can still submit a PFB on Celestia (see
[gist](https://gist.github.com/rootulp/0d16d76814a6169c38ac0e9cca86cc58)).
I don't have a Ledger Nano S+ to test with 😞

(cherry picked from commit 13149fc)

# Conflicts:
#	test/interchain/go.mod
#	test/interchain/go.sum
@mergify mergify bot mentioned this pull request Jan 2, 2025
Merged
rootulp added a commit that referenced this pull request Jan 2, 2025
@mergify @rootulp
fix: ledger nano s+ (backport #4146) (#4172)
29d4409 
Closes #4106 by
upgrading to cosmos-ledger-go v0.14.0

## Testing

I verified that a Ledger Nano X can still submit a PFB on Celestia (see
[gist](https://gist.github.com/rootulp/0d16d76814a6169c38ac0e9cca86cc58)).
I don't have a Ledger Nano S+ to test with 😞 <hr>This is an automatic
backport of pull request #4146 done by [Mergify](https://mergify.com).

---------

Co-authored-by: Rootul P <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ninabarbakadze ninabarbakadze ninabarbakadze approved these changes

@rach-id rach-id rach-id approved these changes

@cmwaters cmwaters Awaiting requested review from cmwaters

Assignees

@rootulp rootulp

Labels
backport:v3.x PR will be backported automatically to the v3.x branch upon merging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade to ledger-go 1.0.0 to fix support for Ledger Nano S+
3 participants
@rootulp @rach-id @ninabarbakadze