fix: handle context cancellations in txsim #2830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rootulp
approved these changes
Nov 8, 2023
Codecov Report
@@ Coverage Diff @@
## main #2830 +/- ##
==========================================
- Coverage 19.80% 19.80% -0.01%
==========================================
Files 144 144
Lines 17398 17403 +5
==========================================
Hits 3446 3446
- Misses 13631 13636 +5
Partials 321 321
|
evan-forbes
added
the
backport:v1.x
mergify bot
pushed a commit
that referenced
this pull request
Nov 10, 2023
I have seen a few CI tests fail because although the context stops the process, it isn't correctly parsed causing the program that called the txsim to think that there was another error and not the context Canceled or DeadlineExceeded errors (cherry picked from commit 5dfe777)
rootulp
pushed a commit
that referenced
this pull request
Nov 10, 2023
This is an automatic backport of pull request #2830 done by [Mergify](https://mergify.com). --- <details> <summary>Mergify commands and options</summary> <br /> More conditions and actions can be found in the [documentation](https://docs.mergify.com/). You can also trigger Mergify actions by commenting on this pull request: - `@Mergifyio refresh` will re-evaluate the rules - `@Mergifyio rebase` will rebase this PR on its base branch - `@Mergifyio update` will merge the base branch into this PR - `@Mergifyio backport <destination>` will backport this PR on `<destination>` branch Additionally, on Mergify [dashboard](https://dashboard.mergify.com) you can: - look at your merge queues - generate the Mergify configuration with the config editor. Finally, you can contact us on https://mergify.com </details> Co-authored-by: Callum Waters <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have seen a few CI tests fail because although the context stops the process, it isn't correctly parsed causing the program that called the txsim to think that there was another error and not the context Canceled or DeadlineExceeded errors