Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore!: delete FitsIntoSquare #2771

Closed
wants to merge 4 commits into from
Closed

chore!: delete FitsIntoSquare #2771

wants to merge 4 commits into from

Conversation

evan-forbes
Copy link
Member

Overview

we should do this regardless of #2770 (and I could swear we already did), but it was conflicting so I'm making a PR to that branch atm.

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

@evan-forbes evan-forbes added the warn:api breaking item will be break an API and require a major bump label Oct 25, 2023
@evan-forbes evan-forbes self-assigned this Oct 25, 2023
@celestia-bot celestia-bot requested a review from a team October 25, 2023 20:28
rootulp
rootulp previously approved these changes Oct 25, 2023
View reviewed changes
Copy link
Collaborator

@rootulp rootulp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. FitsInSquare seems unused outside these locations

Screenshot 2023-10-25 at 4 30 13 PM

@evan-forbes evan-forbes marked this pull request as draft October 25, 2023 23:20
@cmwaters
Copy link
Contributor

It seems that celestia-node also don't import it. We should predominantly be conscious of them and rollkit before removing methods but this LGTM

@evan-forbes
Copy link
Member Author

yeah its a good point we should check with users before removing stuff.

I hope noone is using this! it was introduced forrever ago in the first (or one of the first) versions of the non-interactive defaults

Base automatically changed from evan/commitment-refactor to main October 27, 2023 18:07
@evan-forbes evan-forbes dismissed rootulp’s stale review October 27, 2023 18:07

The base branch was changed.

@rootulp rootulp mentioned this pull request Dec 28, 2023
Closed
@rootulp
Copy link
Collaborator

rootulp commented Dec 28, 2023

A lot of this code has been extracted to https://github.com/celestiaorg/go-square so I think we should close this as won't do and track in celestiaorg/go-square#4.

@rootulp rootulp closed this Dec 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rootulp rootulp rootulp left review comments

@cmwaters cmwaters Awaiting requested review from cmwaters

Assignees

@evan-forbes evan-forbes

Labels
warn:api breaking item will be break an API and require a major bump
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@evan-forbes @cmwaters @rootulp