Increase default recv_rate and send_rate

[rootulp]

Context

celestia-app/Makefile

Lines 337 to 348 in 2e16394

	configure-v3:
	@echo "Using config file at: $(CONFIG_FILE)"
	@if [ "$$(uname)" = "Darwin" ]; then \
	sed -i '' "s/^recv_rate = .*/recv_rate = $(SEND_RECV_RATE)/" $(CONFIG_FILE); \
	sed -i '' "s/^send_rate = .*/send_rate = $(SEND_RECV_RATE)/" $(CONFIG_FILE); \
	sed -i '' "s/ttl-num-blocks = .*/ttl-num-blocks = 12/" $(CONFIG_FILE); \
	else \
	sed -i "s/^recv_rate = .*/recv_rate = $(SEND_RECV_RATE)/" $(CONFIG_FILE); \
	sed -i "s/^send_rate = .*/send_rate = $(SEND_RECV_RATE)/" $(CONFIG_FILE); \
	sed -i "s/ttl-num-blocks = .*/ttl-num-blocks = 12/" $(CONFIG_FILE); \
	fi
	.PHONY: configure-v3

modified the send and receive rates in config file

Problem

The defaults for those fields are still low.

Proposal

1. Increase the defaults so that the configure-v3 command isn't necessary if someone downloads a new binary and generates a new config.
2. Look at the ttl-num-blocks field and see if that default also needs to be bumped

[rootulp]

On the latest v3.x binary, a freshly generated config:

# Rate at which packets can be sent, in bytes/second
send_rate = 5120000

# Rate at which packets can be received, in bytes/second
recv_rate = 5120000

# Note, if ttl-duration is also defined, a transaction will be removed if it
# has existed in the mempool at least ttl-num-blocks number of blocks or if
# it's insertion time into the mempool is beyond ttl-duration.
ttl-num-blocks = 12

And after running the configure-v3 command, they look like this:

# Rate at which packets can be sent, in bytes/second
send_rate = 10485760  

# Rate at which packets can be received, in bytes/second
recv_rate = 10485760  

# Note, if ttl-duration is also defined, a transaction will be removed if it
# has existed in the mempool at least ttl-num-blocks number of blocks or if
# it's insertion time into the mempool is beyond ttl-duration.
ttl-num-blocks = 12

so the TTL num blocks default does not need to be modified. But the send and recv rates do.

[rootulp]

Looks like the rates should already be overridden to 10 MiB but these lines don't work as expected

celestia-app/app/default_overrides.go

Lines 277 to 279 in ada5cde

	const mebibyte = 1048576
	cfg.P2P.SendRate = 10 * mebibyte
	cfg.P2P.RecvRate = 10 * mebibyte

[rootulp]

Looks like inside celestia-core the config is based on serverCtx.Config which has overridden values for other default_overrides like Mempool.TTLDuration but not for P2P.SendRate so digging into why

[rootulp]

The default overrides that we configured are getting overridden by Cosmos SDK https://github.com/celestiaorg/cosmos-sdk/blame/d2163cecdef80591e86d0e5c8c7e6b8f70e2d0ad/server/util.go#L216-L217

[evan-forbes]

sorry didn't mean to close, I think it auto closed with the merging of #celelstiaorg/cosmos-sdk/425

[rootulp]

Yea no worries