Skip to content

Commit

Permalink
feat: increase max-recv-msg-size default to 20 MiB (backport #4205) (#…
Browse files Browse the repository at this point in the history
…4221)

Closes #4204

Note this won't modify already existing `app.toml` files so node
operators need to modify their local `app.toml`. Example command:

```shell
sed -i.bak 's/^max-recv-msg-size = "10485760"/max-recv-msg-size = "20971520"/' ~/.celestia-app/config/app.toml
```

## Testing

```shell
# Before
$ cat ~/.celestia-app/config/app.toml | grep max-recv
max-recv-msg-size = "10485760"

# After
$ ./scripts/single-node.sh
$ cat ~/.celestia-app/config/app.toml | grep max-recv
max-recv-msg-size = "20971520"
```<hr>This is an automatic backport of pull request #4205 done by
[Mergify](https://mergify.com).

Co-authored-by: Rootul P <[email protected]>
  • Loading branch information
mergify[bot] and rootulp authored Jan 14, 2025
1 parent ada5cde commit 6ee9c05
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 0 deletions.
3 changes: 3 additions & 0 deletions app/default_overrides.go
Original file line number Diff line number Diff line change
Expand Up @@ -294,5 +294,8 @@ func DefaultAppConfig() *serverconfig.Config {
cfg.StateSync.SnapshotInterval = 1500
cfg.StateSync.SnapshotKeepRecent = 2
cfg.MinGasPrices = fmt.Sprintf("%v%s", appconsts.DefaultMinGasPrice, BondDenom)

const mebibyte = 1048576
cfg.GRPC.MaxRecvMsgSize = 20 * mebibyte
return cfg
}
3 changes: 3 additions & 0 deletions app/default_overrides_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,9 @@ func TestDefaultAppConfig(t *testing.T) {
assert.Equal(t, uint64(1500), cfg.StateSync.SnapshotInterval)
assert.Equal(t, uint32(2), cfg.StateSync.SnapshotKeepRecent)
assert.Equal(t, "0.002utia", cfg.MinGasPrices)

mebibyte := 1048576
assert.Equal(t, 20*mebibyte, cfg.GRPC.MaxRecvMsgSize)
}

func TestDefaultConsensusConfig(t *testing.T) {
Expand Down

0 comments on commit 6ee9c05

Please sign in to comment.