Bugfix semver parse (#229)

* fix bug in S3 Repo parsing version number from artifact * changelog
carsdotcom · Sep 19, 2022 · 2e1366e · 2e1366e
1 parent 13ffaf4
commit 2e1366e
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -3,7 +3,14 @@ Documenting All Changes to the Skelebot Project
 
 ---
 
+## v1.33.1
+#### Changed
+- **S3Repo** | Fixed a bug in S3Repo where the artifact version was not being parsed properly in some cases
+
+---
+
 ## v1.33.0
+#### Merged: 2022-09-09
 #### Added
 - **Git Templates** | Added the ability to load templates from Git repos in scaffolding
 

diff --git a/VERSION b/VERSION
@@ -1 +1 @@
-1.33.0
+1.33.1
diff --git a/skelebot/components/repository/s3Repo.py b/skelebot/components/repository/s3Repo.py
@@ -70,7 +70,8 @@ def pull(self, artifact, version, currentVersion=None, override=False, user=None
 
             # Iterate through all the artifacts int he bucket
             for content in response["Contents"]:
-                artifactSemver = Semver(str(content["Key"]).split("_v")[1].split(ext)[0])
+                artifactName = str(content["Key"]).split("/")[-1]
+                artifactSemver = Semver(artifactName.split("_v")[-1].split(ext)[0])
 
                 # Find the most recent backward compatible version AKA Latest Compatible Version (LCV)
                 if (currentSemver.isBackwardCompatible(artifactSemver)) and ((version is None) or (version < artifactSemver)):