Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change chunking image to work with dark mode #1716

Merged
merged 2 commits into from
Aug 2, 2024
Merged

Conversation

karenword
Copy link
Contributor

Addresses cited failure in #1715 (not closing because there may be other problems)

Copy link

github-actions bot commented Aug 1, 2024

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

  • 🎯 correct output
  • 🖼️ correct figures
  • ❓ new warnings
  • ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/carpentries/instructor-training/compare/md-outputs..md-outputs-PR-1716

The following changes were observed in the rendered markdown documents:

 05-memory.md            |   2 +-
 fig/chunking2.png (new) | Bin 0 -> 48838 bytes
 md5sum.txt              |   2 +-
 3 files changed, 2 insertions(+), 2 deletions(-)
What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2024-08-01 18:49:58 +0000

github-actions bot pushed a commit that referenced this pull request Aug 1, 2024
@ndporter ndporter merged commit 9376293 into main Aug 2, 2024
3 checks passed
@ndporter ndporter deleted the karenword-chunking-fix branch August 2, 2024 14:45
github-actions bot pushed a commit that referenced this pull request Aug 2, 2024
Auto-generated via {sandpaper}
Source  : 9376293
Branch  : main
Author  : Nathaniel D Porter <[email protected]>
Time    : 2024-08-02 14:45:56 +0000
Message : Merge pull request #1716 from carpentries/karenword-chunking-fix

replace chunking image with PNG to work with dark mode
github-actions bot pushed a commit that referenced this pull request Aug 2, 2024
Auto-generated via {sandpaper}
Source  : 9f9c2ea
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2024-08-02 14:47:00 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 9376293
Branch  : main
Author  : Nathaniel D Porter <[email protected]>
Time    : 2024-08-02 14:45:56 +0000
Message : Merge pull request #1716 from carpentries/karenword-chunking-fix

replace chunking image with PNG to work with dark mode
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants