Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add definition for UNIX in English #497

Merged
merged 2 commits into from
Jul 5, 2022
Merged

Conversation

souravsingh
Copy link
Contributor

@souravsingh souravsingh commented May 26, 2022

Refs #239 for addition of UNIX definition

Author:

Language:

  • English

Terms defined:

  • UNIX

@jsteyn jsteyn self-requested a review May 31, 2022 10:27
@jsteyn jsteyn added the lang: en issues and PR for English entries label Jul 5, 2022
glossary.yml Outdated
en:
term: "UNIX"
def: >
UNIX is a family of [operating systems](#operating-system) developed during
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The slug for "operating system" has an underscore, not a hyphen (because hyphens are special in YAML)

Suggested change
UNIX is a family of [operating systems](#operating-system) developed during
UNIX is a family of [operating systems](#operating_system) developed during

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When this is changed, the tests will pass and we can merge

replace '-' with '_'
@jsteyn jsteyn merged commit e015798 into carpentries:main Jul 5, 2022
@elletjies
Copy link
Member

@souravsingh Thank you for contributing to Glosario in 2022! We are looking forward to receiving more PRs from you during 2023!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lang: en issues and PR for English entries
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants