Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to resolve rlang build error by keeping R from previous action. #21

Merged
merged 1 commit into from
Jun 12, 2024

Conversation

tkphd
Copy link
Contributor

@tkphd tkphd commented Jun 12, 2024

No description provided.

Copy link

ℹ️ Modified Workflows

This pull request contains modified workflow files and no preview will be created.

Workflow files modified:

  • .github/workflows/pr-receive.yaml

If this is not from a trusted source, please inspect the changes for any malicious content.

@tkphd tkphd requested review from ocaisa and reid-a June 12, 2024 18:42
@tkphd
Copy link
Contributor Author

tkphd commented Jun 12, 2024

I am requesting to merge an entirely untested change to the build process, so we can see what happens if this "works," and the skipped, downstream "Build markdown source files if valid" process can succeed. This is untested, and may require reverting this merge to main, but I don't see a way to test the modified Actions without doing this, since PRs with a mix of lesson content and CI changes are blocked by The Carpentries' actions. Ugh.

@reid-a
Copy link
Contributor

reid-a commented Jun 12, 2024

Accepting @tkphd 's assurances that reversion is tedious but not difficult, OKing this.

Copy link
Contributor

@reid-a reid-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FIre when ready.

@tkphd tkphd merged commit 45ffbf5 into carpentries-incubator:main Jun 12, 2024
3 checks passed
@tkphd tkphd deleted the ci-confabulation branch June 12, 2024 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants