Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cluster snakefiles #12

Merged
merged 2 commits into from
Dec 21, 2023
Merged

Cluster snakefiles #12

merged 2 commits into from
Dec 21, 2023

Conversation

reid-a
Copy link
Contributor

@reid-a reid-a commented Dec 20, 2023

There's no real point in keeping the cluster_snakefile stuff separate, it should be merged. We can still edit the snakefiles as we move forward, this isn't an attempt to declare the set to be finalized.

The "Snakefile_cluster_iteration" file manages the list of
widths, and can iterate over jobs on the cluster and then
do a (trivial) aggregation step.

The queuing_config.yaml file is a short cluster config that
removes the need to type the cluster stuff into the command
line.  It conventionally goes in
$HOME/.config/snakemake/queuing/config.yaml, and is accessed
by "snakemake <other-args> --profile=queuing".

The Snakefile has mpi stuff for the trivial aggregation rule
because the cluster-ness of it applies to all the rules.
This is clumsy, but not wrong.
No cluster shenanigans in this one, just straight-up iteration,
maybe a useful intermediate step.
Copy link

github-actions bot commented Dec 20, 2023

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

  • 🎯 correct output
  • 🖼️ correct figures
  • ❓ new warnings
  • ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/carpentries-incubator/hpc-workflows/compare/md-outputs..md-outputs-PR-12

The following changes were observed in the rendered markdown documents:

 files/Snakefile_cluster_iteration (new) | 24 ++++++++++++++++++++++++
 files/Snakefile_iterative (new)         | 13 +++++++++++++
 files/queuing_config.yaml (new)         |  6 ++++++
 3 files changed, 43 insertions(+)
What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2023-12-20 16:13:39 +0000

github-actions bot pushed a commit that referenced this pull request Dec 20, 2023
Copy link
Contributor

@tkphd tkphd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @reid-a!

@tkphd tkphd merged commit a4d7b63 into main Dec 21, 2023
3 checks passed
github-actions bot pushed a commit that referenced this pull request Dec 21, 2023
Auto-generated via {sandpaper}
Source  : a4d7b63
Branch  : main
Author  : Trevor Keller <[email protected]>
Time    : 2023-12-21 12:13:20 +0000
Message : Merge pull request #12 from carpentries-incubator/cluster_snakefiles

Cluster snakefiles
github-actions bot pushed a commit that referenced this pull request Dec 21, 2023
Auto-generated via {sandpaper}
Source  : 3d286cb
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2023-12-21 12:14:34 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : a4d7b63
Branch  : main
Author  : Trevor Keller <[email protected]>
Time    : 2023-12-21 12:13:20 +0000
Message : Merge pull request #12 from carpentries-incubator/cluster_snakefiles

Cluster snakefiles
github-actions bot pushed a commit that referenced this pull request Dec 26, 2023
Auto-generated via {sandpaper}
Source  : 3d286cb
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2023-12-21 12:14:34 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : a4d7b63
Branch  : main
Author  : Trevor Keller <[email protected]>
Time    : 2023-12-21 12:13:20 +0000
Message : Merge pull request #12 from carpentries-incubator/cluster_snakefiles

Cluster snakefiles
github-actions bot pushed a commit that referenced this pull request Jan 2, 2024
Auto-generated via {sandpaper}
Source  : 3d286cb
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2023-12-21 12:14:34 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : a4d7b63
Branch  : main
Author  : Trevor Keller <[email protected]>
Time    : 2023-12-21 12:13:20 +0000
Message : Merge pull request #12 from carpentries-incubator/cluster_snakefiles

Cluster snakefiles
github-actions bot pushed a commit that referenced this pull request Jan 4, 2024
Auto-generated via {sandpaper}
Source  : 3d286cb
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2023-12-21 12:14:34 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : a4d7b63
Branch  : main
Author  : Trevor Keller <[email protected]>
Time    : 2023-12-21 12:13:20 +0000
Message : Merge pull request #12 from carpentries-incubator/cluster_snakefiles

Cluster snakefiles
github-actions bot pushed a commit that referenced this pull request Jan 9, 2024
Auto-generated via {sandpaper}
Source  : 3d286cb
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2023-12-21 12:14:34 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : a4d7b63
Branch  : main
Author  : Trevor Keller <[email protected]>
Time    : 2023-12-21 12:13:20 +0000
Message : Merge pull request #12 from carpentries-incubator/cluster_snakefiles

Cluster snakefiles
github-actions bot pushed a commit that referenced this pull request Jan 16, 2024
Auto-generated via {sandpaper}
Source  : 3d286cb
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2023-12-21 12:14:34 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : a4d7b63
Branch  : main
Author  : Trevor Keller <[email protected]>
Time    : 2023-12-21 12:13:20 +0000
Message : Merge pull request #12 from carpentries-incubator/cluster_snakefiles

Cluster snakefiles
github-actions bot pushed a commit that referenced this pull request Jan 23, 2024
Auto-generated via {sandpaper}
Source  : 3d286cb
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2023-12-21 12:14:34 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : a4d7b63
Branch  : main
Author  : Trevor Keller <[email protected]>
Time    : 2023-12-21 12:13:20 +0000
Message : Merge pull request #12 from carpentries-incubator/cluster_snakefiles

Cluster snakefiles
github-actions bot pushed a commit that referenced this pull request Jan 30, 2024
Auto-generated via {sandpaper}
Source  : 3d286cb
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2023-12-21 12:14:34 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : a4d7b63
Branch  : main
Author  : Trevor Keller <[email protected]>
Time    : 2023-12-21 12:13:20 +0000
Message : Merge pull request #12 from carpentries-incubator/cluster_snakefiles

Cluster snakefiles
github-actions bot pushed a commit that referenced this pull request Feb 6, 2024
Auto-generated via {sandpaper}
Source  : 3d286cb
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2023-12-21 12:14:34 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : a4d7b63
Branch  : main
Author  : Trevor Keller <[email protected]>
Time    : 2023-12-21 12:13:20 +0000
Message : Merge pull request #12 from carpentries-incubator/cluster_snakefiles

Cluster snakefiles
github-actions bot pushed a commit that referenced this pull request Feb 13, 2024
Auto-generated via {sandpaper}
Source  : 3d286cb
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2023-12-21 12:14:34 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : a4d7b63
Branch  : main
Author  : Trevor Keller <[email protected]>
Time    : 2023-12-21 12:13:20 +0000
Message : Merge pull request #12 from carpentries-incubator/cluster_snakefiles

Cluster snakefiles
github-actions bot pushed a commit that referenced this pull request Feb 20, 2024
Auto-generated via {sandpaper}
Source  : 3d286cb
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2023-12-21 12:14:34 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : a4d7b63
Branch  : main
Author  : Trevor Keller <[email protected]>
Time    : 2023-12-21 12:13:20 +0000
Message : Merge pull request #12 from carpentries-incubator/cluster_snakefiles

Cluster snakefiles
github-actions bot pushed a commit that referenced this pull request Feb 27, 2024
Auto-generated via {sandpaper}
Source  : 3d286cb
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2023-12-21 12:14:34 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : a4d7b63
Branch  : main
Author  : Trevor Keller <[email protected]>
Time    : 2023-12-21 12:13:20 +0000
Message : Merge pull request #12 from carpentries-incubator/cluster_snakefiles

Cluster snakefiles
github-actions bot pushed a commit that referenced this pull request Mar 5, 2024
Auto-generated via {sandpaper}
Source  : 3d286cb
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2023-12-21 12:14:34 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : a4d7b63
Branch  : main
Author  : Trevor Keller <[email protected]>
Time    : 2023-12-21 12:13:20 +0000
Message : Merge pull request #12 from carpentries-incubator/cluster_snakefiles

Cluster snakefiles
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants