Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Require Numpy major version smaller than 2 #257

Merged

Conversation

jhlegarreta
Copy link
Contributor

Require Numpy major version smaller than 2: with the recent release of Numpy 2 a number of dependencies have started to fail, so require Numpy major versions smaller than 2 until dependencies adapt to Numpy 2.0.

Fixes:

AttributeError  Traceback (most recent call last)
AttributeError: _ARRAY_API not found

reported for example in:
https://github.com/carpentries-incubator/SDC-BIDS-dMRI/actions/runs/9655229240/job/26630796981#step:13:65

Numpy 2.0.0 release notice:
https://numpy.org/news/#numpy-200-released

Require Numpy major version smaller than 2: with the recent release of
Numpy 2 a number of dependencies have started to fail, so require Numpy
major versions smaller than 2 until dependencies adapt to Numpy 2.0.

Fixes:
```
AttributeError  Traceback (most recent call last)
AttributeError: _ARRAY_API not found
```

reported for example in:
https://github.com/carpentries-incubator/SDC-BIDS-dMRI/actions/runs/9655229240/job/26630796981#step:13:65

Numpy 2.0.0 release notice:
https://numpy.org/news/#numpy-200-released
Copy link

github-actions bot commented Jun 27, 2024

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

  • 🎯 correct output
  • 🖼️ correct figures
  • ❓ new warnings
  • ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/carpentries-incubator/SDC-BIDS-dMRI/compare/md-outputs..md-outputs-PR-257

The following changes were observed in the rendered markdown documents:


What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2024-06-27 23:02:24 +0000

Copy link

netlify bot commented Jun 27, 2024

Deploy Preview for sdc-bids-dmri failed.

Name Link
🔨 Latest commit e4e01e5
🔍 Latest deploy log https://app.netlify.com/sites/sdc-bids-dmri/deploys/667deee78bbd1d00084bf333

github-actions bot pushed a commit that referenced this pull request Jun 27, 2024
@jhlegarreta jhlegarreta merged commit 4359838 into carpentries-incubator:main Jun 28, 2024
7 of 11 checks passed
@jhlegarreta jhlegarreta deleted the LimitNumpyVersion branch June 28, 2024 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant