Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update pull_request_template.md #65

Merged
merged 1 commit into from
Nov 23, 2024
Merged

Update pull_request_template.md #65

merged 1 commit into from
Nov 23, 2024

Conversation

kaijagahm
Copy link
Collaborator

Just a simple update for our own use

@peterlaurin

@kaijagahm
Update pull_request_template.md
fa15716 
Just a simple update for our own use
@kaijagahm kaijagahm requested a review from peterlaurin October 2, 2024 21:36
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 2, 2024

ℹ️ Modified Workflows

This pull request contains modified workflow files and no preview will be created.

Workflow files modified:

  • .github/pull_request_template.md

If this is not from a trusted source, please inspect the changes for any malicious content.

@kaijagahm
Copy link
Collaborator Author

@peterlaurin can you quickly review this and merge it in?

peterlaurin
peterlaurin approved these changes Nov 23, 2024
View reviewed changes
Copy link
Collaborator

@peterlaurin peterlaurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@peterlaurin peterlaurin merged commit 96901a7 into main Nov 23, 2024
3 checks passed
@peterlaurin peterlaurin deleted the kaijagahm-patch-3 branch November 23, 2024 01:30
github-actions bot pushed a commit that referenced this pull request Nov 23, 2024
@actions-user
markdown source builds
3ef1074 
Auto-generated via `{sandpaper}`
Source  : 96901a7
Branch  : main
Author  : peterlaurin <[email protected]>
Time    : 2024-11-23 01:30:07 +0000
Message : Merge pull request #65 from carpentries-incubator/kaijagahm-patch-3

Update pull_request_template.md
github-actions bot pushed a commit that referenced this pull request Nov 23, 2024
@actions-user
site deploy
f590807 
Auto-generated via `{sandpaper}`
Source  : 3ef1074
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2024-11-23 01:31:01 +0000
Message : markdown source builds

Auto-generated via `{sandpaper}`
Source  : 96901a7
Branch  : main
Author  : peterlaurin <[email protected]>
Time    : 2024-11-23 01:30:07 +0000
Message : Merge pull request #65 from carpentries-incubator/kaijagahm-patch-3

Update pull_request_template.md
xortizross added a commit that referenced this pull request Dec 3, 2024
@xortizross
Squashed commit of the following:
3bce90e 
commit 04fc52c
Merge: 66501ae ff995ea
Author: Xochitl Ortiz-Ross <[email protected]>
Date:   Tue Dec 3 14:04:57 2024 -0800

    Merge pull request #79 from carpentries-incubator/peter_edits

    changed relative path to load data

commit ff995ea
Author: peterlaurin <[email protected]>
Date:   Tue Dec 3 14:01:18 2024 -0800

    changed relative path to load data

commit 66501ae
Merge: b2ef676 c7d87b9
Author: Xochitl Ortiz-Ross <[email protected]>
Date:   Tue Dec 3 13:34:33 2024 -0800

    Merge pull request #78 from carpentries-incubator/peter_edits

    added identify the problem episode for review, Dec2024. Changed to Rm…

commit c7d87b9
Author: peterlaurin <[email protected]>
Date:   Tue Dec 3 12:44:26 2024 -0800

    removed open tag for carpentries

commit d419691
Author: peterlaurin <[email protected]>
Date:   Tue Dec 3 12:35:55 2024 -0800

    fixed further bugs

commit ad93365
Author: peterlaurin <[email protected]>
Date:   Tue Dec 3 12:19:41 2024 -0800

    fixed some last-minute R bugs

commit b2ef676
Merge: d8b86da d82aa3b
Author: peterlaurin <[email protected]>
Date:   Tue Dec 3 12:04:53 2024 -0800

    Merge pull request #77 from carpentries-incubator/xochitl_edits

    small edits

commit c1af304
Merge: 97eed2e d8b86da
Author: peterlaurin <[email protected]>
Date:   Tue Dec 3 12:01:33 2024 -0800

    Merge branch 'main' into peter_edits

commit 97eed2e
Author: peterlaurin <[email protected]>
Date:   Tue Dec 3 11:41:51 2024 -0800

    changed config to allow Rmd file for Peter's episode to run

commit 3a8d5b8
Author: peterlaurin <[email protected]>
Date:   Tue Dec 3 11:25:36 2024 -0800

    added identify the problem episode for review, Dec2024. Changed to Rmd to run R.

commit d8b86da
Merge: 96901a7 782e862
Author: peterlaurin <[email protected]>
Date:   Fri Nov 22 17:38:06 2024 -0800

    Merge pull request #73 from carpentries-incubator/minimal-reproducible-code-draft

    Minimal reproducible code draft -- Resolved discrepancy in yaml with md and Rmd

commit 782e862
Merge: 761d64f 96901a7
Author: peterlaurin <[email protected]>
Date:   Fri Nov 22 17:32:47 2024 -0800

    Merge branch 'main' into minimal-reproducible-code-draft

commit 96901a7
Merge: 5a23b4b fa15716
Author: peterlaurin <[email protected]>
Date:   Fri Nov 22 17:30:07 2024 -0800

    Merge pull request #65 from carpentries-incubator/kaijagahm-patch-3

    Update pull_request_template.md

commit 761d64f
Author: Kaija Gahm <[email protected]>
Date:   Fri Nov 22 17:00:33 2024 -0800

    Draft entire episode except for exercise content

commit 7ce1de3
Author: Kaija Gahm <[email protected]>
Date:   Fri Nov 22 10:58:19 2024 -0800

    fixed merge conflicts

commit 5a23b4b
Merge: 2335e86 ea9aecf
Author: Kaija Gahm <[email protected]>
Date:   Wed Nov 6 13:58:13 2024 -0800

    Merge pull request #69 from carpentries-incubator/xochitl_edits

    Xochitl edits

commit 449d69f
Merge: 5c85579 5210f72
Author: Kaija Gahm <[email protected]>
Date:   Wed Oct 23 14:57:12 2024 -0700

    fixed merge conflict

    Merge branch 'minimal-reproducible-code-draft' of github.com:carpentries-incubator/R-help-reprexes into minimal-reproducible-code-draft

    # Conflicts:
    #	episodes/5-minimal-reproducible-code.Rmd

commit 5c85579
Author: Kaija Gahm <[email protected]>
Date:   Wed Oct 23 14:29:36 2024 -0700

    15:00 end work session

commit 5210f72
Author: Kaija Gahm <[email protected]>
Date:   Wed Oct 23 14:29:36 2024 -0700

    2:30 end work session

commit 3ccd70e
Author: Kaija Gahm <[email protected]>
Date:   Wed Oct 23 14:03:56 2024 -0700

    sketching more exercises. reordered road map slightly.

commit 1817002
Author: Kaija Gahm <[email protected]>
Date:   Thu Oct 17 13:16:40 2024 -0700

    remembered ??fun shortcut for searching

commit 2265911
Author: Kaija Gahm <[email protected]>
Date:   Wed Oct 16 15:00:23 2024 -0700

    First draft of lesson text for the first part of the road map

commit c73f662
Author: Kaija Gahm <[email protected]>
Date:   Wed Oct 16 14:39:05 2024 -0700

    full episode outline

commit d95d7cc
Author: Kaija Gahm <[email protected]>
Date:   Wed Oct 16 14:26:29 2024 -0700

    Updated LOs for Ep5; moved {reprex} to Ep6

commit 8c33a45
Author: Kaija Gahm <[email protected]>
Date:   Wed Oct 16 14:13:58 2024 -0700

    Moved progress from last week to .Rmd from .md

commit fa15716
Author: Kaija Gahm <[email protected]>
Date:   Wed Oct 2 14:36:28 2024 -0700

    Update pull_request_template.md

    Just a simple update for our own use

commit 2ec2b16
Author: Kaija Gahm <[email protected]>
Date:   Wed Oct 2 14:03:26 2024 -0700

    First crack at narrative and a first exercise

commit dcb0d48
Author: Kaija Gahm <[email protected]>
Date:   Wed Oct 2 13:27:14 2024 -0700

    added LOs from google doc, and corresponding questions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterlaurin peterlaurin peterlaurin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kaijagahm @peterlaurin