Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review #9

Merged
merged 2 commits into from
Oct 1, 2024
Merged

Review #9

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5987f30
Review
Oddant1 Oct 1, 2024
0cdb17e
dictionary
Oddant1 Oct 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions book/references/parallel-configuration.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,8 +87,6 @@ strategy = "None"
is a top-level Parsl configuration parameter that you can [read more about in the Parsl documentation](https://parsl.readthedocs.io/en/stable/userguide/configuring.html#multi-threaded-applications).
This may need to be set differently depending on your system.

If you were to load this into Python using tomlkit you would get the following dictionary:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no dictionary following this line. We probably don't need this at all, alternatively we can add in the dictionary, but if we are only going to do that in one place I would probably do it for a more complex case lower down.


Next, the first executor is added.

```
Expand Down Expand Up @@ -161,6 +159,8 @@ This implies that after your first time running QIIME 2 in parallel without a co
Alternatively, when using {term}`q2cli`, you can provide a specific configuration for use in configuring parsl using the `--parallel-config` option.
If provided, this overrides the priority order above.

Similarly, when using the {term}`Python 3 API`, you can provide a specific configuration by passing a `parsl.Config` object into your `ParallelConfig` context manager.

````{admonition} user_config_dir and site_config_dir
:class: note
On Linux, `user_config_dir` will usually be `$HOME/.config/qiime2/`.
Expand Down
2 changes: 1 addition & 1 deletion book/tutorials/parallel-pipeline.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ If you're using a system with parallel computing capabilities (e.g., at least si

## Python 3 API

Parallel Pipeline execution through the Python API is done using a `parsl.Config` object as a context manager.
Parallel Pipeline execution through the Python API is done using a `ParallelConfig` object as a context manager.
These objects take a `parsl.Config` object and an optional dictionary mapping action names to executor names as input.
If no config is provided your default configuration will be used (see [](qiime2-configuration-precedence)).

Expand Down