Ignore whatsapp-web.js type definition - Fix #600 #602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
|
There is a PR on whatsapp-web.js that will change the definition of the Location received too, so next update will have to be adapted. |
antoniosaints
approved these changes
Nov 30, 2023
w3nder
approved these changes
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like whatsapp-web.js on version 1.23.0 changed the type definition of Location, mostly because a change on how to send the location. They removed the values for name, address, url and description from the Location object and created an Option object that includes only name, address and url.
BUT, received location stills come with the old format AND the code fails to build because of the type differences.
This pull request make whaticket compatible with whatsapp-web.js 1.23.0 bypassing typescript checks for two lines that uses the location.description value of messages.
I will open an issue on whatsapp-web.js so we can remove this bypass on the future.