Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix django-debug env variable #34

Merged
merged 1 commit into from
Jun 28, 2024
Merged

Fix django-debug env variable #34

merged 1 commit into from
Jun 28, 2024

Conversation

javierdelapuente
Copy link
Collaborator

@javierdelapuente javierdelapuente commented Jun 27, 2024

Overview

DEBUG Django configuration is always True, as it should be a bool and not a string.

Just when the env variable DJANGO_DEBUG is "true", put DEBUG to True, otherwise DEBUG should be False.

Rationale

Juju Events Changes

Module Changes

Library Changes

Checklist

@javierdelapuente javierdelapuente added trivial bug Something isn't working labels Jun 27, 2024
@javierdelapuente javierdelapuente marked this pull request as ready for review June 27, 2024 15:30
@javierdelapuente javierdelapuente requested a review from a team as a code owner June 27, 2024 15:30
Copy link

@merkata merkata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

Test coverage for ffb9bfc

Name           Stmts   Miss Branch BrPart  Cover   Missing
----------------------------------------------------------
src/charm.py     134     64     28      2    47%   67-69, 101-106, 124-135, 146-151, 159-188, 201, 209, 213, 217, 221, 238-246, 253-259, 269-279, 294, 302, 318, 379
----------------------------------------------------------
TOTAL            134     64     28      2    47%

Static code analysis report

Run started:2024-06-28 07:20:59.045845

Test results:
  No issues identified.

Code scanned:
  Total lines of code: 1038
  Total lines skipped (#nosec): 1
  Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 0

Run metrics:
  Total issues (by severity):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
  Total issues (by confidence):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
Files skipped (0):

@javierdelapuente javierdelapuente merged commit 36dcca3 into main Jun 28, 2024
18 checks passed
@javierdelapuente javierdelapuente deleted the fix-debug branch June 28, 2024 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working trivial
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants