[DPE-5588] Check against invalid arch #344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sinclert-canonical
requested review from
taurus-forever,
shayancanonical and
carlcsaposs-canonical
sinclert-canonical
force-pushed
the
sinclert/5588/arch-check
branch
2 times, most recently
from
7303df9 to
d80bcef
Compare
carlcsaposs-canonical
approved these changes
Dec 13, 2024
sinclert-canonical
force-pushed
the
sinclert/5588/arch-check
branch
from
d80bcef to
60fab7b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the usage of the newly created architecture module, similar to the one in the MySQL lib (see code).
The shape of the integration tests, as well as the helper used to get the built charm in the architecture that mismatches the one of the host itself, have been adapted from the one Lucas created for PostgreSQL-k8s (see code).
Additional info