Network clustering

[edlerd]

Done

• adjust network list to show cluster member specific networks
• split network list entries and detail pages to be one entry/page per cluster member for physical interfaces
• add pattern for cluster specific inputs for a physical managed networks parent. This is to be reused for other cluster specific inputs like in server settings or for storage pool configuration

QA

1. Run the LXD-UI:
   • On the demo server via the link posted by @webteam-app below. This is only available for PRs created by collaborators of the repo. Ask @mas-who or @edlerd for access.
   • With a local copy of this branch, build and run as described in the docs.
2. Perform the following QA steps:
   • Browse the network list in an unclustered backend, check the filters
   • Browse the network list in a clustered backend, use the filters and clicking on the cluster member chips applies filtering
   • Create and edit a physical network in an unclustered backend
   • Create and edit a physical network in a clustered backend, ensure the connections diagram is updating and the chips in it linking correctly. Ensure the chips in the "parent" selector link correctly. Try changing and breaking the parent selector in the clustered backend when creating or editing a physical network.
   • Browse a physical unmanaged network in a clustered and unclustered backend

[webteam-app]

Demo

Jenkins

demos.haus

[MasWho]

Some interim code comments. The network list with filtering looks pretty good (cluster and non-cluster conditions) from QA perspective. Will go through the other QA items as well.

[mas-who]

Some QA observations below:

1. When clicking on the cluster member resource links in the network list table, all existing search params gets cleared. Why not add the the member search to the existing search params? Is it because it would be a bit weird in the case that the member search is already present, and it would look like nothing is happening?

2. Noticed that on smaller screen sizes the action buttons and the search filter are positioned weirdly. Maybe we can add the actions in a contextual menu similar to how we do it in the instance detail page. Then there will be more space for the search and filter as well. wdyt?
   

3. When creating a clustered physical network with the following parent configs
   
   On submission I get the following error:
   
   Trying to create the network with the same name fails at this point as it already exist in LXD.
   
   I think we should disable the submit button if parents are not selected for all members?
   NOTE: the edit case seems fine, the backend seems to block the operation and the configs does not get persisted.

4. After creating a physical network with some parent interface across cluster members, trying to create another network using the same parent interfaces results in a creation error indicating they are in use. However, the network still gets created in an "Errored" state.

5. Clicking on the member resource link on a network detail page does not result in search params being set after redirect to the network list page. Is that intended?

6. After creating an OVN network with a physical uplink, it is possible to delete the physical uplink. However, on the network topology for the OVN network, the deleted uplink still shows up some how.

7. Observations for when a cluster member is down:
   a. Trying to create a physical network results in an error message "peer node 10.94.160.130:8443 is down". However, the network gets created and shows up in the network list with the "Cluster-wide" member category.
   b. It is not possible to edit a physical network with the same error message as above.
   c. It is not possible to delete the physical network with the same error message as above.
   d. trying to visit the physical network detail page for the vm that is down results in a 500 error "Missing event connection with target cluster member". Currently the detail page loads for a long time then shows a blank page, this should probably be handled by displaying the error message.

[edlerd]

Resolved issues 1-3 and 5.

4. After creating a physical network with some parent interface across cluster members, trying to create another network using the same parent interfaces results in a creation error indicating they are in use. However, the network still gets created in an "Errored" state.

This sounds like the expected behaviour. Wdyt?

6. After creating an OVN network with a physical uplink, it is possible to delete the physical uplink. However, on the network topology for the OVN network, the deleted uplink still shows up some how.

This shows up, because the uplink config of the OVN network doesn't change when deleting the uplink network. It might be that LXD should refuse to delete the uplink, but that should be in the API then, not in the UI itself.

7. Observations for when a cluster member is down:
   a. Trying to create a physical network results in an error message "peer node 10.94.160.130:8443 is down". However, the network gets created and shows up in the network list with the "Cluster-wide" member category.
   b. It is not possible to edit a physical network with the same error message as above.
   c. It is not possible to delete the physical network with the same error message as above.
   d. trying to visit the physical network detail page for the vm that is down results in a 500 error "Missing event connection with target cluster member". Currently the detail page loads for a long time then shows a blank page, this should probably be handled by displaying the error message.

This needs future work.

[mas-who]

Resolved issues 1-3 and 5.

4. After creating a physical network with some parent interface across cluster members, trying to create another network using the same parent interfaces results in a creation error indicating they are in use. However, the network still gets created in an "Errored" state.

This sounds like the expected behaviour. Wdyt?

My main concern is that the network gets created even when it's not valid. Would it be possible to check upon parent selection if it is already used by another network and reflect that as an error message on the creation / edit form? If that's too complex I think the current behaviour is also fine.

6. After creating an OVN network with a physical uplink, it is possible to delete the physical uplink. However, on the network topology for the OVN network, the deleted uplink still shows up some how.

This shows up, because the uplink config of the OVN network doesn't change when deleting the uplink network. It might be that LXD should refuse to delete the uplink, but that should be in the API then, not in the UI itself.

Noted, perhaps we should raise this with the core team?

7. Observations for when a cluster member is down:
   a. Trying to create a physical network results in an error message "peer node 10.94.160.130:8443 is down". However, the network gets created and shows up in the network list with the "Cluster-wide" member category.
   b. It is not possible to edit a physical network with the same error message as above.
   c. It is not possible to delete the physical network with the same error message as above.
   d. trying to visit the physical network detail page for the vm that is down results in a 500 error "Missing event connection with target cluster member". Currently the detail page loads for a long time then shows a blank page, this should probably be handled by displaying the error message.

This needs future work.
Noted 👍

[edlerd]

Improved the error handling, that should resolve 7.

4. After creating a physical network with some parent interface across cluster members, trying to create another network using the same parent interfaces results in a creation error indicating they are in use. However, the network still gets created in an "Errored" state.

This sounds like the expected behaviour. Wdyt?

My main concern is that the network gets created even when it's not valid. Would it be possible to check upon parent selection if it is already used by another network and reflect that as an error message on the creation / edit form? If that's too complex I think the current behaviour is also fine.

I am not 100% sure we can never reuse an interface as parent. Reported this edge case to lxd: canonical/lxd#14810

6. After creating an OVN network with a physical uplink, it is possible to delete the physical uplink. However, on the network topology for the OVN network, the deleted uplink still shows up some how.

This shows up, because the uplink config of the OVN network doesn't change when deleting the uplink network. It might be that LXD should refuse to delete the uplink, but that should be in the API then, not in the UI itself.

Noted, perhaps we should raise this with the core team?

I tried to reproduce it, but was getting an error. I couldn't delete the uplink in use by the OVN network. So this might not be an issue after all.

[mas-who]

This is looking really good! Couldn't actually find that many issues QA wise, left some code comments

[mas-who]

QA comments:

1. On medium screen size, the network list table gets cut off, should we make the table width adjust with viewport width until they turn into cards?
   

2. When creating a physical network, should we pre-select a network interface when the "Same for all cluster members" option is checked?

[edlerd]

All open issues mentioned above should be resolved.