Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a boolean
queryable
property to the WMS model to indicate if a layer is queryable via GetFeatureInfo or not.The
queryable
property is an optional attribute on the WMS Layer with either a '1' (is queryable) or '0' (not queryable). If the attribute doesn't exist it should be assumed it is not queryable.Possible Issues
queryable
attribute can be inherited, but I have never seen a real world example where this occurs. This PR does not handle that possibility and will revert to a layer being notqueryable
if the attribute doesn't exist on the layer. This could be improved but I'm not sure how and whether its worth the effort at this point.queryable
attribute is equal to the string "1". I see no reason this shouldn't work in all cases, but better implementation ideas are welcomequeryable
, there are no tests for a 'true'opaque
) which I've ignored, as queryable is currently the only one I care about.