Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Calyx-Backend] Use Morty to link external libraries #2378

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

[Calyx-Backend] Use Morty to link external libraries #2378

wants to merge 10 commits into from

Conversation

jiahanxie353
Copy link
Collaborator

This patch is the first half of #1928

We use Morty: https://github.com/pulp-platform/morty to pickle Verilog/System Verilog files needed as libraries.

Acknowledgement to @evanmwilliams for the original implementation.

@jiahanxie353 jiahanxie353 self-assigned this Dec 17, 2024
ekiwi
ekiwi reviewed Dec 18, 2024
View reviewed changes
calyx-backend/src/verilog.rs Outdated Show resolved Hide resolved
@jiahanxie353
Copy link
Collaborator Author

Also added HardFloat as a compilation library; as well as corresponding tests cases.

Ready for another round of review, thanks!

ekiwi
ekiwi reviewed Jan 6, 2025
View reviewed changes
calyx-backend/src/verilog.rs Outdated Show resolved Hide resolved
ekiwi
ekiwi requested changes Jan 6, 2025
View reviewed changes
Copy link
Contributor

@ekiwi ekiwi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some questions / potential for improvement.

ekiwi
ekiwi approved these changes Jan 7, 2025
View reviewed changes
Copy link
Contributor

@ekiwi ekiwi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All my comments have been addressed. We need to hear from @rachitnigam before this is merged, since it is a pretty major change to a part of the codebase that I am not familiar with.

@jiahanxie353
Copy link
Collaborator Author

All my comments have been addressed. We need to hear from @rachitnigam before this is merged, since it is a pretty major change to a part of the codebase that I am not familiar with.

sounds good, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekiwi ekiwi ekiwi approved these changes

@rachitnigam rachitnigam Awaiting requested review from rachitnigam

Assignees

@jiahanxie353 jiahanxie353

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jiahanxie353 @ekiwi