Support generic assert_eq #2
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 1bfb7ad.
for +=, -=, *=
Support hint function
Add += functionality
This option allows variables that are not constrained.
better contributing file
…-check-option Add --disable-safety-check option
…yword_as_identifier Improve error when a keyword is used as identifier
Add boolean flag to skip argument type checking of builtin functions.
fix potential uint overflow
|
why is this one a draft :o ? |
Implement generic log
I fortgot to target the main branch after zksecurity#231 was merged. Creating a full pr now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using zksecurity#231
I disabled the argument type checking for assert_eq. Then implemented the recursive comparison for Array and structs. Note that we don't need to handle GenericSizedArrays since they will be monophormized by the time assert_eq is executed.
There is also a test for checking some nested structs and Arrays.