Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use kwargs for tv_setactiveshape parameters #10

Merged
merged 1 commit into from
Apr 22, 2024
Merged

Use kwargs for tv_setactiveshape parameters #10

merged 1 commit into from
Apr 22, 2024

Conversation

jhenrybrunch
Copy link
Contributor

For the tv_set_active_shape function, if you want to set the shape parameters you need to do that:

george.tv_set_active_shape(george.TVPShape.RECTANGLE, "aaliasing", 0)

With the fix, using kwargs is more pythonic:

george.tv_set_active_shape(george.TVPShape.RECTANGLE, aaliasing=0)

(reported by @kstrandli)

@jhenrybrunch jhenrybrunch requested a review from rlahmidi April 4, 2024 14:58
@rlahmidi rlahmidi merged commit 0b63e2f into main Apr 22, 2024
1 check passed
@rlahmidi rlahmidi deleted the set-active-shape-kwargs branch April 22, 2024 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rlahmidi rlahmidi Awaiting requested review from rlahmidi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jhenrybrunch @rlahmidi