Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Real time wpm and acc #8

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

[WIP] Real time wpm and acc #8

wants to merge 14 commits into from

Conversation

Grivel-l
Copy link

@Grivel-l Grivel-l commented Jul 1, 2019

No description provided.

@briano1905
Copy link
Owner

Hi I appreciate your contribution to the project

I ran it on my local machine and it works wonderfully great job! But I'm not sure if want this to replace the current indicator. It's a bit too distracting and I like seeing my previous WPM and ACC.

I'm really sorry I can't merge this

@briano1905 briano1905 closed this Jul 1, 2019
@Grivel-l
Copy link
Author

Grivel-l commented Jul 2, 2019

Maybe we could add an option to enable the feature ?

@briano1905
Copy link
Owner

Hi Grivel sorry I shouldn't have closed this pull request my bad. This is my first collaborative project on GitHub. Yes we can definitely make that an optional feature. Could you implement it the same way I did for punctuation option and disabled by default? That would be great :)

@briano1905 briano1905 reopened this Jul 2, 2019
@Grivel-l
Copy link
Author

Grivel-l commented Jul 3, 2019

No problem, done, you can enable it with mod + r

@briano1905
Copy link
Owner

Thank you for adding the changes but there are a few problem I found:

  • wpm keeps dropping after the user finish the typing test
  • and the accuracy is not 100 when the user typed everything correctly

@Grivel-l Grivel-l changed the title Real time wpm and acc [WIP] Real time wpm and acc Jul 5, 2019
@braydonburn
Copy link

Couple of things:

  1. Probably want to add how to activate this mode in the readme
  2. When in wordcount mode the WPM continues to drop once done

SeerLite added a commit to SeerLite/typings that referenced this pull request Dec 18, 2020
SeerLite added a commit to SeerLite/typings that referenced this pull request Dec 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants