Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: replace Biconomy with internal meta-tx-gateway #1112

Merged
merged 9 commits into from
Dec 23, 2024

Conversation

levalleux-ludo
Copy link
Member

@levalleux-ludo levalleux-ludo commented Dec 5, 2024

Description

  • Core components dependencies are upgraded to use the internal meta-tx gateway instead of Biconomy.
  • NOTE: Upgrade of core-components implies upgrade of Yup dependency version, meaning a few adaptation required (mostly type matching)
  • In addition, the dApp now supports an env var to override the gatewayUrl. However this is optional (and not useful now the core-components is using the new gateway)
  • The env var can be set differently on TESTING. STAGING and PRODUCTION deployment if needed. Again this is optional, as the default values from the core-components are the one to be used.
  • The apiKeys and apiIds initially defined for Biconomy are still supported without requiring any change (everyone can keep their .env file as is)

How to test

Check the network connection when submitting a transaction.
FYI, here are the new Urls, per env:

see more here: https://github.com/bosonprotocol/meta-tx-gateway/blob/main/docs/deployments.md

@levalleux-ludo levalleux-ludo requested a review from a team as a code owner December 5, 2024 19:00
Copy link

cloudflare-workers-and-pages bot commented Dec 5, 2024

Deploying interface with  Cloudflare Pages  Cloudflare Pages

Latest commit: 10e5689
Status: ✅  Deploy successful!
Preview URL: https://dfed691c.interface-a9d.pages.dev
Branch Preview URL: https://meta-tx-gateway.interface-a9d.pages.dev

View logs

Copy link
Contributor

@albertfolch-redeemeum albertfolch-redeemeum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comments

@levalleux-ludo levalleux-ludo merged commit bbbae9e into main Dec 23, 2024
13 checks passed
@levalleux-ludo levalleux-ludo deleted the meta-tx-gateway branch December 23, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants