Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: setup chromatic for storybook #680

Merged
merged 19 commits into from
Mar 15, 2024

Conversation

albertfolch-redeemeum
Copy link
Collaborator

@albertfolch-redeemeum albertfolch-redeemeum commented Mar 14, 2024

Copy link

codecov bot commented Mar 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.33%. Comparing base (13e0a24) to head (405c8e7).
Report is 33 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #680      +/-   ##
==========================================
+ Coverage   84.72%   88.33%   +3.61%     
==========================================
  Files         132      145      +13     
  Lines        4248     5376    +1128     
  Branches      734      794      +60     
==========================================
+ Hits         3599     4749    +1150     
+ Misses        649      627      -22     
Flag Coverage Δ
common 85.11% <ø> (?)
core-sdk 59.29% <ø> (+9.16%) ⬆️
e2e 85.88% <ø> (+2.70%) ⬆️
eth-connect-sdk 97.26% <ø> (?)
ethers-sdk 69.38% <ø> (?)
ipfs-storage 90.90% <ø> (?)
metadata 94.70% <ø> (?)
unittests 62.64% <ø> (+12.51%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@levalleux-ludo levalleux-ludo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@albertfolch-redeemeum albertfolch-redeemeum merged commit ec6ae41 into main Mar 15, 2024
11 checks passed
@albertfolch-redeemeum albertfolch-redeemeum deleted the setup-chromatic-storybook branch March 15, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants