Add multiple fee receivers #4294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix some conflicts from an earlier rebase
ripcurlx
approved these changes
Jun 25, 2020
There was a problem hiding this comment.
ACK - tested it locally on Regtest with 40+ trades and the random and weighted selection seems to work. I also tested removing addresses from the filter after a couple of transactions. The only thing I recognized is an existing issue with the Filter propagation right now which is addressed in #4335.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a rebased version of #4150 with @stejbac's patch applied.
I still worry about the filter distribution but it might be a minor issue compared to adding some kind of cutoff date and extra complexity that way. I have tested this and it seems to work. The only think I can't get to work locally is the propagation of remove filter. It could be an issue of applying recently received filters though, need to look a bit more at it.
@stejbac Do you have any other issues with this PR. Simple is good to adding more stuff indeed less desirable unless we really do need it.