-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the broken badge, add coding guidelines and simplify PR/issue templates #86
Changes from 5 commits
f21ef48
7ef7b27
e8acee9
50d743f
3d05485
6c7e465
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,33 @@ | ||
--- | ||
name: Bug report | ||
about: Create a report to help us improve | ||
title: '' | ||
labels: bug | ||
assignees: '' | ||
|
||
--- | ||
|
||
## Checklist before submitting an issue | ||
|
||
- [ ] I have checked the [existing issues](https://github.com/biomarkersParkinson/tsdf/issues) and couldn't find an issue about this bug. | ||
|
||
## Bug details | ||
|
||
**Describe the bug** | ||
|
||
A clear and concise description of what the bug is. | ||
|
||
**To Reproduce** | ||
|
||
Steps to reproduce the behavior: | ||
1. install `tsdf` using pip | ||
2. run method `example_method` with parameters | ||
3. ... | ||
|
||
**Error Message** | ||
|
||
If applicable, add the error message. | ||
|
||
**Expected behavior** | ||
|
||
A clear and concise description of what you expected to happen. |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
--- | ||
name: Feature request | ||
about: Suggest an idea for this project | ||
title: '' | ||
labels: enhancement | ||
assignees: '' | ||
|
||
--- | ||
|
||
## Checklist before submitting an issue | ||
|
||
- [ ] I have checked the [existing issues](https://github.com/biomarkersParkinson/tsdf/issues) and couldn't find an issue about this bug. | ||
|
||
## Feature details | ||
|
||
**Feature Description** | ||
A clear and concise description of the feature you're proposing. | ||
|
||
**Problem and Motivation** | ||
Please describe the problem you are facing or the limitation with the current setup. Explain the motivation behind this feature request. For example, "I'm always frustrated when [...]." |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
--- | ||
name: Blank issue | ||
about: Any other issue | ||
title: '' | ||
labels: '' | ||
assignees: '' | ||
|
||
--- | ||
|
||
## Checklist before submitting an issue | ||
|
||
- [ ] I have checked the [existing issues](https://github.com/biomarkersParkinson/tsdf/issues) and couldn't find an issue about this bug. | ||
|
||
## Issue details | ||
<!-- | ||
Whatever you write here must have something to do with the code you get from running `copier`. | ||
--> |
This file was deleted.
This file was deleted.
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
@@ -0,0 +1,24 @@ | ||||||
## Describe your changes | ||||||
|
||||||
Please include a summary of the changes and the related issue. Please also include relevant motivation and context. | ||||||
|
||||||
## Type of change | ||||||
|
||||||
Please delete options that are not relevant. | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Since you suggest working with checkboxes here, perhaps simply (un)checking is sufficient. |
||||||
|
||||||
- [ ] Bug fix | ||||||
- [ ] New feature | ||||||
- [ ] Other | ||||||
|
||||||
## Issue ticket number and link | ||||||
|
||||||
<!-- add all related issues to the list below --> | ||||||
Refs: | ||||||
- #ISSUE_NUMBER_1 | ||||||
- #ISSUE_NUMBER_2 | ||||||
|
||||||
## Checklist before requesting a review | ||||||
|
||||||
- [ ] I have read the [contribution guidelines](https://github.com/biomarkersParkinson/tsdf/blob/main/CONTRIBUTING.md) | ||||||
- [ ] I have commented my code, particularly in hard-to-understand areas | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Not sure, but perhaps this is more appropriate phrasing. |
||||||
- [ ] I have added tests that prove my fix is effective or that my feature works |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,44 +1,24 @@ | ||
--- | ||
name: Pull Request | ||
about: Create a pull request to contribute to the project | ||
title: '' | ||
labels: '' | ||
assignees: '' | ||
## Describe your changes | ||
|
||
--- | ||
Please include a summary of the changes and the related issue. Please also include relevant motivation and context. | ||
|
||
## Description | ||
<!-- Provide a detailed description of the changes or features implemented in this pull request. Explain the problem it solves or the feature it adds to the project. --> | ||
## Type of change | ||
|
||
## Related Issue(s) | ||
<!-- List related issues or tasks that this pull request addresses. Use the format `#issue_number` to automatically link them here. --> | ||
Please delete options that are not relevant. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Similar changes as in prior suggestion if agreed upon. |
||
|
||
## Type of Change | ||
<!-- Identify the type of change(s) made in this pull request. Check all that apply. --> | ||
- [ ] Bug fix | ||
- [ ] New feature | ||
- [ ] Enhancement to an existing feature | ||
- [ ] Documentation update | ||
- [ ] Other (please specify): | ||
- [ ] Other | ||
|
||
## How Has This Been Tested? | ||
<!-- Describe the tests that you ran to verify your changes. Include relevant details for your test configuration or mention which tests cover these changes. --> | ||
## Issue ticket number and link | ||
|
||
## Checklist | ||
- [ ] I have followed the project's style guidelines. | ||
- [ ] My code includes relevant unit tests to cover my changes. | ||
- [ ] I have updated the documentation to reflect my changes (if applicable). | ||
- [ ] My changes do not introduce any new warnings or errors. | ||
- [ ] I have performed a self-review of my own code. | ||
- [ ] All new and existing unit tests pass successfully with my changes. | ||
- [ ] My commit messages are clear and meaningful. | ||
<!-- add all related issues to the list below --> | ||
Refs: | ||
- #ISSUE_NUMBER_1 | ||
- #ISSUE_NUMBER_2 | ||
|
||
## Additional Notes | ||
<!-- Include any additional information, or notes that may be relevant or helpful to reviewers. --> | ||
|
||
## Impact | ||
<!-- Describe any potential impacts this change may have on the project. This can include, but is not limited to, performance implications, changes in behavior, or dependency updates. --> | ||
|
||
## Reviewer(s) | ||
<!-- Optionally tag any specific reviewers you would like to review your pull request. --> | ||
## Checklist before requesting a review | ||
|
||
- [ ] I have read the [contribution guidelines](https://github.com/biomarkersParkinson/tsdf/blob/main/CONTRIBUTING.md) | ||
- [ ] I have commented my code, particularly in hard-to-understand areas | ||
- [ ] I have added tests that prove my fix is effective or that my feature works |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the reason you suggest to have this table at the top of the issue/PR? It confuses me a little, in particular because the "about" is also clarified at "bug details", "name" is similar to "labels", and "assignees" is usually chosen manually. What am I missing here?