Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove setuptools.command.test as it is no longer supported. #985

Closed
wants to merge 1 commit into from

Conversation

mataton
Copy link
Collaborator

@mataton mataton commented Dec 2, 2024

Support for the test command was removed in setuptools 72. Currently, BIOM relies on this command to manage unit tests. However, if one runs make test on the current codebase, you'll see RuntimeError: Support for the test command was removed in Setuptools 72. This PR is a simple implementation to remove BIOM's dependency on this unsupported function. However, it may not be the ideal solution. More seasoned members of the BIOM dev team, please feel free to review and critique this approach.

@mataton
Copy link
Collaborator Author

mataton commented Dec 2, 2024

Additional info here.

@wasade
Copy link
Member

wasade commented Dec 2, 2024

Thanks, it looks like this may avoid Cython compilation?

wasade added a commit to wasade/biom-format that referenced this pull request Dec 2, 2024
@wasade
Copy link
Member

wasade commented Dec 3, 2024

Merged into #986

@wasade wasade closed this Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants