its not clear that we need this.

bigskysoftware · Jan 14, 2025 · 369e4fd · 369e4fd
1 parent 1c19fdd
commit 369e4fd
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 33 deletions.
diff --git a/src/idiomorph.js b/src/idiomorph.js
@@ -473,13 +473,8 @@ var Idiomorph = (function () {
     function moveBefore(parentNode, element, after) {
       // @ts-ignore - use proposed moveBefore feature
       if (parentNode.moveBefore) {
-        try {
-          // @ts-ignore - use proposed moveBefore feature
-          parentNode.moveBefore(element, after);
-        } catch (e) {
-          // fall back to insertBefore as some browsers may fail on moveBefore when trying to move Dom disconnected nodes to pantry
-          parentNode.insertBefore(element, after);
-        }
+        // @ts-ignore - use proposed moveBefore feature
+        parentNode.moveBefore(element, after);
       } else {
         parentNode.insertBefore(element, after);
       }

diff --git a/test/retain-hidden-state.js b/test/retain-hidden-state.js
@@ -338,32 +338,6 @@ describe("Hidden state preservation tests", function () {
     states.should.eql([true]);
   });
 
-  it("check moveBefore function fails back to insertBefore if moveBefore fails", function () {
-    getWorkArea().append(
-      make(`
-            <div>
-              <input type="checkbox" id="first">
-              <input type="checkbox" id="second">
-            </div>
-        `),
-    );
-    // replace moveBefore function with a boolean which will fail the try catch
-    document.getElementById("first").parentNode.moveBefore = true;
-    document.getElementById("second").parentNode.moveBefore = true;
-
-    let finalSrc = `
-            <div>
-              <input type="checkbox" id="second">
-              <input type="checkbox" id="first">
-            </div>
-        `;
-    Idiomorph.morph(getWorkArea(), finalSrc, {
-      morphStyle: "innerHTML",
-    });
-
-    getWorkArea().innerHTML.should.equal(finalSrc);
-  });
-
   it("check moveBefore function falls back to insertBefore if moveBefore is missing", function () {
     getWorkArea().append(
       make(`