Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default industry #733

Merged
merged 2 commits into from
Dec 6, 2024
+3 −2
Merged

Default industry #733

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2ceefb3
Make generated file/example have a valid industry
PatrikStenmark Dec 6, 2024
4f185cf
Add mention of validation task to README
PatrikStenmark Dec 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ Proudly built with [Phoenix](https://phoenixframework.org).
website: "https://example.com/",
github: "https://github.com/example/acme-corp",
# reference lib/companies/industries.ex for a list of recommended industries to use here
industry: "Technology",
industry: "Information Technology",
location: %{
city: "City",
state: "State",
Expand All @@ -42,6 +42,7 @@ Proudly built with [Phoenix](https://phoenixframework.org).
}
```

- Run `mix validate_company_file priv/companies/your-new-file.exs` to validate the new company file.
- Create a pull request adding the new company file

## Development
Expand Down
2 changes: 1 addition & 1 deletion lib/mix/tasks/create_company_file.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ defmodule Mix.Tasks.CreateCompanyFile do
website: "https://example.com/",
github: "https://github.com/example/#{file_name}",
# reference lib/companies/industries.ex for a list of recommended industries to use here
industry: "Technology",
industry: "Information Technology",
location: %{
city: "City",
state: "State",
Expand Down
Loading