Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: Add new diversity classification diversityMM for composite characters and similar. #2611

Merged
merged 11 commits into from
Dec 10, 2024

Conversation

jmcwilliams403
Copy link
Contributor

@jmcwilliams403 jmcwilliams403 commented Dec 8, 2024

This effectively makes composite characters, including W/w/m, perfectly proportional with the characters their individual components are derived from. This does not universally apply to all characters, as many characters already look proportional as-is.

AꜲÆꜴꜶBCDÐEƎƏFGHIJKLMN
ᴬ𐞀ᴭᴭᴭᴮꟲᴰᶞᴱᴲᴲꟳᴳᴴᴵᴶᴷᴸᴹᴺ
ᴀᴁᴁᴁᴁʙᴄᴅᴆᴇⱻⱻꜰɢʜɪᴊᴋʟᴍɴ
aꜳæꜵꜷbcdðeɘəfghijklmn
ᵃ𐞃𐞃𐞃𐞃ᵇᶜᵈᶞᵉ𐞎ᵊᶠᵍʰⁱʲᵏˡᵐⁿ
OŒꝎPQRSSTUƜƜƜVWXYZÞẞ
ᴏɶɶᴘꞯʀꜱꜱᴛᴜꟺꟺꟺᴠᴡxʏᴢ
ᴼ𐞣𐞣ᴾꟴᴿˢˢᵀᵁᵂᵂᵂⱽᵂˣ𐞲ᶻ
oœꝏpqrſstuᵫꭣɯvwxyzþß
ᵒꟹꟹᵖ𐞥ʳˢˢᵗᵘᵚᵚᵚᵛʷˣʸᶻ

Aile Latin before:
image
Aile Latin After:
image
Etoile Latin Before:
image
Etoile Latin After:
image

АꙖБВГЃҐҔДꙢꚈЂԂЕЀЁҼҾѤЄѤ
аꙗбвгѓґҕдꙣꚉђԃеѐёҽҿꭡєѥ
𞀰𞀰𞀱𞀲𞀳𞀳́𞀳𞀳𞀴𞀴𞁊𞀴𞀴𞀵𞀵̀𞀵̈𞀵𞀵𞀵𞀵𞀵
ЖԪꚄЗҘԄЅИІЇЍЙЈҠКЌӃЛЉԈꙤԠ
жԫꚅзҙԅѕиіїѝйјҡкќӄлљԉꙥԡ
𞀶𞀶𞀶𞀷𞀷𞀷𞀷𞀸𞁌𞁌̈𞀸̀𞀸̆𞁍𞀹𞀹́𞀹𞀹𞀺𞀺𞀺𞀺𞀺
МꙦНЊԊҤԢОЮꙔППҦРСҪТᲉԎꚊЋУЎ
мꙧнњԋҥԣоюꙕпꭠҧрсҫтᲊԏꚋћуў
𞀻𞀻ᵸᵸᵸᵸᵸ𞀼𞁉𞁉𞀽𞀽𞀽𞀾𞀿𞁫𞁀𞁀𞁀𞁀𞁀𞁁𞁁̆
ФХӼԔԖЦҴЧꚆꚒЏШЩꙐЪЫЬѢꙒЭЯ
фхӽԕԗцҵчꚇꚓџшщꙑъыьѣꙓэя
𞁂𞁃𞁃𞁃𞁃𞁄𞁄𞁅𞁅𞁅𞁅𞁆𞁆𞁬ꚜ𞁇ꚝꚝ𞁇𞁈

Aile Cyrillic Upright Before:
image
Aile Cyrillic Upright After:
image
Aile Cyrillic Italic Before:
image
Aile Cyrillic Italic After:
image
Etoile Cyrillic Upright Before:
image
Etoile Cyrillic Upright After:
image
Etoile Cyrillic Italic Before:
image
Etoile Cyrillic Italic After:
image

@be5invis
Copy link
Owner

be5invis commented Dec 8, 2024

Looks nice.

@be5invis be5invis marked this pull request as ready for review December 8, 2024 20:30
Copy link
Owner

@be5invis be5invis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments are listed below.

In addition, please attach before/after samples of the text in sentences / longer text.

packages/font-glyphs/src/letter/greek/lower-omega.ptl Outdated Show resolved Hide resolved
packages/font-glyphs/src/letter/cyrillic/zhe.ptl Outdated Show resolved Hide resolved
packages/font-glyphs/src/letter/greek/phi.ptl Outdated Show resolved Hide resolved
@jmcwilliams403
Copy link
Contributor Author

jmcwilliams403 commented Dec 8, 2024

Regarding ef and images of sentences:
image
image

@jmcwilliams403
Copy link
Contributor Author

I will work on your requested changes later.

@jmcwilliams403
Copy link
Contributor Author

jmcwilliams403 commented Dec 9, 2024

Changes to Greek are reverted. Rather than taking more screenshots of Greek text, I removed the Greek section from the body of my PR.

@jmcwilliams403
Copy link
Contributor Author

Regarding Ԕ/Ԗ/ԕ/ԗ
Ԕ/ԕ are perfect already, while Ԗ/ԗ could stand be adjusted some other way besides simply making the whole character wider, because the Х/х parts are already too wide since they only use half of the x-shape.

@be5invis be5invis merged commit d030b12 into be5invis:dev Dec 10, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants