Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding revpi connect 4 support #1078

Merged
merged 1 commit into from
Dec 5, 2023
Merged

Adding revpi connect 4 support #1078

merged 1 commit into from
Dec 5, 2023

Conversation

wickywaka
Copy link

@wickywaka wickywaka commented Oct 30, 2023 •
edited
Loading

In this PR we are adding support for revpi-connect-4. This is very similar to what we did for the revpi-connect-s here #1016

@floion is there a way you can run the tests for this? This seems to be working on our devices but we are happy to fix issues that might arise during testing.

@nbuchwitz would be great if you can have a look at this.

@resin-jenkins
Copy link

Can one of the admins verify this patch?

@wickywaka wickywaka closed this Oct 30, 2023
@wickywaka wickywaka reopened this Oct 31, 2023
@wickywaka wickywaka force-pushed the revpi-connect-4 branch 3 times, most recently from a7c27d8 to 883e7f7 Compare November 6, 2023 13:17
@wickywaka wickywaka changed the title Draft: revpi connect 4 support Adding revpi connect 4 support Nov 6, 2023
@nbuchwitz
Copy link
Contributor

@floion just spoke with Kenna last week. We will ship you the hardware (afaik to a partner in UK). If it will help I can reroute the shipment to you. Just let me know.

@floion
Copy link
Collaborator

floion commented Nov 7, 2023

Thanks @wickywaka we'll review it.
@nbuchwitz great, thanks. No need to have it rerouted here, for the moment we want to have the boards with our partner in the UK.

@wickywaka
Copy link
Author

@floion I think this is ready for testing. Anyway we can get this merged quickly so that we can continue with testing our devices.

floion
floion reviewed Nov 22, 2023
View reviewed changes
revpi-connect-4.coffee Outdated Show resolved Hide resolved
@wickywaka wickywaka force-pushed the revpi-connect-4 branch 2 times, most recently from 52525b4 to d6846c6 Compare November 22, 2023 09:55
@wickywaka
Copy link
Author

For now I will just try to create a working with changes proposed by @nbuchwitz and once we have a working image, then I will squash all the commits.

@floion Why don't you guys squash the commits automatically from a PR (may be with a template message) so that all the PR is just one commit. That way the contributor does not have to do all the rebases manually and can focus on final result.

@wickywaka wickywaka force-pushed the revpi-connect-4 branch 2 times, most recently from 518079d to 2a50266 Compare November 23, 2023 11:58
@wickywaka
Copy link
Author

@nbuchwitz @floion ready for review again.

nbuchwitz
nbuchwitz approved these changes Nov 23, 2023
View reviewed changes
Copy link
Contributor

@nbuchwitz nbuchwitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So far I can check LGTM

@floion floion enabled auto-merge November 23, 2023 13:36
@floion
Copy link
Collaborator

floion commented Nov 24, 2023

@resin-jenkins test this please

@wickywaka
Copy link
Author

@resin-jenkins test this please

Some of the tests seems to be failing. Can you check the logs and see what is missing?

@floion
Copy link
Collaborator

floion commented Nov 25, 2023

@resin-jenkins test this please

1 similar comment
@floion
Copy link
Collaborator

floion commented Nov 27, 2023

@resin-jenkins test this please

@floion
Copy link
Collaborator

floion commented Nov 27, 2023

@wickywaka the failures are not related to this PR

@rcooke-warwick
Copy link
Contributor

@floion test-raspberrypi will always fail until #1081 merges

revpi-connect-4: Added support for revpi-connect-4 device
2cfad44 
This adds supports for revpi-connect-4. These changes were done by looking at the PR for the
revpi-connect-s.

Changelog-entry: Added support for revpi-connect-4 device
Signed-off-by: Waqar Rashid <[email protected]>
auto-merge was automatically disabled December 1, 2023 10:27

Head branch was pushed to by a user without write access

@wickywaka
Copy link
Author

@resin-jenkins test this please

@floion floion enabled auto-merge December 4, 2023 09:18
@floion
Copy link
Collaborator

floion commented Dec 4, 2023

@resin-jenkins test this please

@wickywaka
Copy link
Author

@floion Can you see why are these tests failing? Is there a way for us to run these tests so that we can reduce the iteration time.

@floion floion merged commit 0078d50 into balena-os:master Dec 5, 2023
46 checks passed
@floion
Copy link
Collaborator

floion commented Dec 6, 2023 •
edited
Loading

@wickywaka looking into #1083. Once that is merged we can release this device type. The failure seem to be related to flaky network issues. The tests need to be ran on the automated test rig, so it would not help if you run the tests on your side.

@wickywaka wickywaka mentioned this pull request Dec 13, 2023
Open
@chrblabla
Copy link

@floion now that #1083 is merged, can we get this device type released?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@floion floion floion approved these changes

@nbuchwitz nbuchwitz nbuchwitz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@wickywaka @resin-jenkins @nbuchwitz @floion @rcooke-warwick @chrblabla