-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Raise error early for MLFlow in local container mode #4993
Open
ruiliann666
wants to merge
2
commits into
aws:master
Choose a base branch
from
ruiliann666:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+10
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruiliann666
had a problem deploying
to
manual-approval
January 14, 2025 00:34 — with
GitHub Actions
Error
ruiliann666
had a problem deploying
to
manual-approval
January 14, 2025 00:42 — with
GitHub Actions
Error
gwang111
reviewed
Jan 14, 2025
ruiliann666
had a problem deploying
to
manual-approval
January 14, 2025 19:17 — with
GitHub Actions
Error
gwang111
reviewed
Jan 14, 2025
ruiliann666
requested a deployment
to
manual-approval
January 14, 2025 19:31 — with
GitHub Actions
Waiting
gwang111
approved these changes
Jan 14, 2025
nargokul
reviewed
Jan 16, 2025
Comment on lines
+886
to
+895
|
||
if self.mode == Mode.LOCAL_CONTAINER and ( | ||
self.model_metadata and ( | ||
"MLFLOW_MODEL_PATH" in self.model_metadata or | ||
"MLFLOW_TRACKING_ARN" in self.model_metadata | ||
) | ||
): | ||
raise ValueError("MLflow model support is not available for Mode.LOCAL_CONTAINER. " | ||
"Please use Mode.SAGEMAKER_ENDPOINT for MLflow models.") | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a unit test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
We should fail early for non support MLflow models.
Customer input:
Description of changes:
Raise error early for MLFlow in local container mode
Testing done:
Merge Checklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.General
Tests
unique_name_from_base
to create resource names in integ tests (if appropriate)By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.