Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise error early for MLFlow in local container mode #4993

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ruiliann666
Copy link
Contributor

@ruiliann666 ruiliann666 commented Jan 14, 2025

Issue #, if available:

We should fail early for non support MLflow models.

Customer input:

model_builder = ModelBuilder(
    name='DogBreedClassifier',
    mode=Mode.LOCAL_CONTAINER,
    schema_builder=my_schema,
    role_arn=role_arn,
    model_metadata={
        # both model path and tracking server ARN are required if you use an mlflow run ID or mlflow model registry path as input
        "MLFLOW_MODEL_PATH": model_uri,
        "MLFLOW_TRACKING_ARN": tracking_uri
    }
)

Description of changes:
Raise error early for MLFlow in local container mode

Testing done:

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • I have read the CONTRIBUTING doc
  • I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
  • I used the commit message format described in CONTRIBUTING
  • I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
  • I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
  • I have checked that my tests are not configured for a specific region or account (if appropriate)
  • I have used unique_name_from_base to create resource names in integ tests (if appropriate)
  • If adding any dependency in requirements.txt files, I have spell checked and ensured they exist in PyPi

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Comment on lines +886 to +895

if self.mode == Mode.LOCAL_CONTAINER and (
self.model_metadata and (
"MLFLOW_MODEL_PATH" in self.model_metadata or
"MLFLOW_TRACKING_ARN" in self.model_metadata
)
):
raise ValueError("MLflow model support is not available for Mode.LOCAL_CONTAINER. "
"Please use Mode.SAGEMAKER_ENDPOINT for MLflow models.")

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a unit test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants