Add Sharding Support for Neo Optimization Jobs #4924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashishgupta023
had a problem deploying
to
manual-approval
GitHub Actions
Error
lanqingzi
reviewed
Nov 12, 2024
| if sharding_config and (quantization_config or compilation_config or speculative_decoding_config): | ||
| raise ValueError("Sharding config is mutually exclusive and cannot be combined with any other optimization.") | ||
|
|
||
| if sharding_config and ((env_vars and "OPTION_TENSOR_PARALLEL_DEGREE" not in env_vars) or (sharding_config.get("OverrideEnvironment") and "OPTION_TENSOR_PARALLEL_DEGREE" not in sharding_config["OverrideEnvironment"])): |
There was a problem hiding this comment.
side note, the same validation is also performed in NeoLambda
ashishgupta023
had a problem deploying
to
manual-approval
GitHub Actions
Error
ashishgupta023
had a problem deploying
to
manual-approval
GitHub Actions
Error
ashishgupta023
had a problem deploying
to
manual-approval
GitHub Actions
Error
lanqingzi
approved these changes
Nov 13, 2024
ashishgupta023
had a problem deploying
to
manual-approval
GitHub Actions
Failure
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes: Add Sharding Support for Neo Optimization Jobs
Testing done: Tested manually on local on mac by building the wheel and running the optimize function
Added Unit Tests
Tested E2E manually on local mac