-
Notifications
You must be signed in to change notification settings - Fork 947
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New serverless pattern - apigw-websocket-api-lambda-authorizer #2004
New serverless pattern - apigw-websocket-api-lambda-authorizer #2004
Conversation
Valid pattern file found. Reviewer you can view the pattern file here |
@bfreiberg - I have made the requested changes. Can you please verify? |
Looks good, thank you for your contribution. The PR will be merged soon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm sorry but there a couple of spelling issues that need to be adjusted.
apigw-websocket-api-lambda-authorizer/apigw-websocket-api-lambda-authorizer.json
Show resolved
Hide resolved
apigw-websocket-api-lambda-authorizer/apigw-websocket-api-lambda-authorizer.json
Show resolved
Hide resolved
apigw-websocket-api-lambda-authorizer/apigw-websocket-api-lambda-authorizer.json
Show resolved
Hide resolved
apigw-websocket-api-lambda-authorizer/apigw-websocket-api-lambda-authorizer.json
Show resolved
Hide resolved
apigw-websocket-api-lambda-authorizer/apigw-websocket-api-lambda-authorizer.json
Show resolved
Hide resolved
@bfreiberg - Hey Ben, I have made the requested changes, and raised a new PR here - #2048. Can you please have a look? |
Hi @ankushjain358, you likely see it already on #2048 but the changes look good and should be merged soon |
Issue #, if available:
Description of changes: New serverless pattern WebSocket API Cognito Authentication using Lambda Authorizer
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.