Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New serverless pattern - apigw-websocket-api-lambda-authorizer #2004

Conversation

ankushjain358
Copy link
Contributor

Issue #, if available:

Description of changes: New serverless pattern WebSocket API Cognito Authentication using Lambda Authorizer

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link

github-actions bot commented Jan 4, 2024

Valid pattern file found.

Reviewer you can view the pattern file here

@ankushjain358
Copy link
Contributor Author

@bfreiberg - I have made the requested changes. Can you please verify?

@bfreiberg
Copy link
Contributor

Looks good, thank you for your contribution. The PR will be merged soon.

@benjasl-stripe benjasl-stripe merged commit b580d42 into aws-samples:main Jan 11, 2024
2 checks passed
Copy link
Contributor

@bfreiberg bfreiberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sorry but there a couple of spelling issues that need to be adjusted.

@ankushjain358
Copy link
Contributor Author

@bfreiberg - Hey Ben, I have made the requested changes, and raised a new PR here - #2048. Can you please have a look?

@bfreiberg
Copy link
Contributor

Hi @ankushjain358, you likely see it already on #2048 but the changes look good and should be merged soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants