-
Notifications
You must be signed in to change notification settings - Fork 308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: hide table rows while results are loading #6089
Closed
jordanvn
wants to merge
32
commits into
feat-storage-browser/main
from
feat-storage-browser/table-load-state
Closed
Changes from all commits
Commits
Show all changes
32 commits
Select commit
Hold shift + click to select a range
6711204
chore: move loading indicator into table, hide table contents while l…
jordanvn 662eaea
Merge branch 'feat-storage-browser/main' into feat-storage-browser/ta…
jordanvn 9c6034d
place loading indicator outside of table, resize table based on contents
jordanvn e352bd6
Merge branch 'feat-storage-browser/main' into feat-storage-browser/ta…
jordanvn 1491905
chore: update styling to allow full vertical scrolling for table
jordanvn 0fac109
chore(tests): update tests to fit new approach to loading
jordanvn 4538b9c
Merge branch 'feat-storage-browser/main' into feat-storage-browser/ta…
jordanvn 04bca01
chore: move loading label to prop, return null instead of false, retu…
jordanvn 4b9e70e
chore: removing duplicate data-testid
jordanvn 56f4097
chore: moving data-table view out of table component and into data ta…
jordanvn fdd7a20
chore: move loading indicator element to data, process label at view …
jordanvn 29b3617
fix(tests): update data in tests to include new changes
jordanvn bf3030e
chore: change loading indicator to react node, make isLoading optional
jordanvn b7e4da4
chore: pass in isLoading at view level, remove isLoading from tableData
jordanvn 9cb48ef
chore: remove unnecessary usage of isLoading, destructure data
jordanvn 82d996a
chore: use object shorthand
jordanvn 24bd121
Merge branch 'feat-storage-browser/main' into feat-storage-browser/ta…
jordanvn ac34eda
Merge branch 'feat-storage-browser/main' into feat-storage-browser/ta…
jordanvn 60887c5
Merge branch 'feat-storage-browser/main' into feat-storage-browser/ta…
jordanvn a30db2f
chore: removing loading indicator component in favor of composable
jordanvn d4adb68
Merge branch 'feat-storage-browser/main' into feat-storage-browser/ta…
jordanvn 015a70a
Merge branch 'feat-storage-browser/main' into feat-storage-browser/ta…
jordanvn 3077998
chore: set isLoading to true on loading indicator composables
jordanvn d3cd630
Merge branch 'feat-storage-browser/main' into feat-storage-browser/ta…
jordanvn 93a796c
Merge branch 'feat-storage-browser/main' into feat-storage-browser/ta…
jordanvn e79f718
Merge branch 'feat-storage-browser/main' into feat-storage-browser/ta…
jordanvn 013b42f
Merge branch 'feat-storage-browser/main' into feat-storage-browser/ta…
jordanvn b878f2d
Merge branch 'feat-storage-browser/main' into feat-storage-browser/ta…
jordanvn e376108
chore: removing usage of loading indicator inside table
jordanvn dcd69aa
chore: removing unnecessary usage of loading indicator and loading in…
jordanvn 2ebf0e6
chore: reverting now-unnecessary style changes
jordanvn 95fcac5
chore: remove unnecessary inclusion of optional isLoading prop, fix u…
jordanvn File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no change to this section, it is just wrapped in conditional logic