-
Notifications
You must be signed in to change notification settings - Fork 308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: StorageManager prop corrections #5543
base: main
Are you sure you want to change the base?
docs: StorageManager prop corrections #5543
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left one comment but otherwise LGTM. Thanks for contributing!
9370826
to
c57132b
Compare
c57132b
to
2d5453b
Compare
Description of changes
Corrected the type of the
file
argument of ttheprocessFile
callback inStorageManager
: it was listed asBlob
, and should beFile
.Also updated
CONTRIBUTING.md
to add the necessaryyarn install
step and explained whynvm use
is valuable.Description of how you validated changes
I was not actually able to build or run the docs; the instructions in the Local Development Guides are insufficient. I waded through many issues, but finally had to give up for now...I'll take a look at that another time and if I fix it, I'll submit a PR for that doc update.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.