Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure part is up for some 100 ms before resetting it #1939

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

stefanrueger
Copy link
Collaborator

Fixes #1929

Would need some regression testing and confirmation it really helps ... @PeterHouseJr?

@mcuee mcuee added the bug Something isn't working label Jan 7, 2025
@stefanrueger
Copy link
Collaborator Author

@mcuee @MCUdude Would you be available for some regression testing on this PR?

@PeterHouseJr
Copy link

PeterHouseJr commented Jan 15, 2025 via email

@stefanrueger
Copy link
Collaborator Author

@PeterHouseJr We typically want independent confimration that this specific pull request compiles and works as expected. The easiest way to do this is to head over to https://github.com/stefanrueger/avrdude/tree/linuxspi-start then click on the green code button to download a zip of that directory. Then best to build the specific avrdude according to your OS as in the wiki https://github.com/avrdudes/avrdude/wiki

Then run the compiled new version and test with your setting. Thanks!

@mcuee
Copy link
Collaborator

mcuee commented Jan 17, 2025

Yes I will try out some simple tests soon. I believe this PR should be fine.

@mcuee
Copy link
Collaborator

mcuee commented Jan 17, 2025

No issues on my Raspberry Pi 400.

mcuee@raspberrypi400arm64:~/build/avrdude_sr/build_linux/src $ ./avrdude -p m328p -c linuxspi -P /dev/spidev0.0:/dev/gpiochip0:25 -v
Avrdude version 8.0-20250106 (713241f9)
Copyright see https://github.com/avrdudes/avrdude/blob/main/AUTHORS

System wide configuration file is /home/mcuee/build/avrdude_sr/build_linux/src/avrdude.conf
User configuration file is /home/mcuee/.avrduderc

Using port            : /dev/spidev0.0:/dev/gpiochip0:25
Using programmer      : linuxspi
Defaulting bit clock to 200 kHz
AVR part              : ATmega328P
Programming modes     : SPM, ISP, HVPP, debugWIRE
Programmer type       : linuxspi
Description           : Use Linux SPI device in /dev/spidev*

AVR device initialized and ready to accept instructions
Device signature = 1E 95 0F (ATmega328P, ATA6614Q, LGT8F328P)

Avrdude done.  Thank you.

mcuee@raspberrypi400arm64:~/build/avrdude_sr/tools $ ./test-avrdude -e ../build_linux/src/avrdude -c ../build_linux/src/avrdude.conf -p "-p m328p -c linuxspi -P /dev/spidev0.0:/dev/gpiochip0:25"
Testing ../build_linux/src/avrdude 8.0-20250106 (713241f9)
Prepare "-p m328p -c linuxspi -P /dev/spidev0.0:/dev/gpiochip0:25" and press 'enter' or 'space' to continue. Press any other key to skip
✅   0.384 s: fuse access: clear, set and read eesave fuse bit
✅   0.287 s: fuse access: set eesave fusebit to delete EEPROM on chip erase
✅   0.340 s: chip erase
✅   2.642 s: flash -U write/verify holes_rjmp_loops_32768B.hex
✅   2.488 s: flash -T write/verify holes_rjmp_loops_32768B.hex
✅   0.306 s: eeprom check whether programmer can flip 0s to 1s
✅   1.358 s: eeprom -U write/verify holes_pack_my_box_1024B.hex
✅   2.316 s: eeprom -T write/verify holes_{the_five_boxing_wizards,pack_my_box}_1024B.hex
✅   1.458 s: chip erase and spot check flash is actually erased
✅   0.346 s: spot check eeprom is erased, too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v8 linuxspi won't connect - Reset Line Inverted ???
3 participants