Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add DNS records #330

Merged
merged 5 commits into from
Sep 9, 2024
Merged

add DNS records #330

merged 5 commits into from
Sep 9, 2024

Conversation

DaMandal0rian
Copy link
Member

@DaMandal0rian DaMandal0rian commented Jul 23, 2024

PR Type

Enhancement


Description

  • Added multiple DNS records for autonomys.xyz including A, CNAME, MX, TXT (SPF, DMARC).
  • Added data sources for autonomys.xyz and subspace.foundation zones.
  • Added DNS records for staging and production environments of safe wallet services.
  • Added DNS records for subspace.foundation including A and MX records.

Changes walkthrough 📝

Relevant files
Enhancement
autonomys-xyz.tf
Add DNS records for autonomys.xyz domain                                 

dns/autonomys-xyz.tf

  • Added multiple DNS records for autonomys.xyz including A, CNAME, MX,
    TXT (SPF, DKIM, DMARC).
  • +71/-0   
    data.tf
    Add data sources for autonomys.xyz and subspace.foundation zones

    dns/data.tf

  • Added data sources for autonomys.xyz and subspace.foundation zones.
  • +10/-0   
    records.tf
    Add DNS records for safe wallet services                                 

    dns/records.tf

  • Added DNS records for staging and production environments of safe
    wallet services.
  • +135/-0 
    subspace-foundation.tf
    Add DNS records for subspace.foundation domain                     

    dns/subspace-foundation.tf

  • Added DNS records for subspace.foundation including A and MX records.
  • +29/-0   

    💡 PR-Agent usage:
    Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

    Copy link

    PR Reviewer Guide 🔍

    ⏱️ Estimated effort to review: 3 🔵🔵🔵⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Key issues to review

    Possible Misconfiguration
    The TTL for DMARC, SPF, and DKIM records is set to 1 second (ttl = 1). This is unusually low and might cause frequent DNS lookups, potentially affecting performance. Consider adjusting the TTL to a more typical value for these types of records.

    Hardcoded IP
    The A records for autonomys.xyz are using hardcoded IP addresses. This could lead to issues if the IP addresses need to change. Consider using a more dynamic method of managing these IPs or ensure there is a process in place for updating them.

    Copy link

    github-actions bot commented Jul 23, 2024

    PR Code Suggestions ✨

    CategorySuggestion                                                                                                                                    Score
    Security
    Adjust DMARC policy to reject to enhance email security

    For the DMARC record, consider adjusting the policy from quarantine to reject to
    ensure stricter handling of emails that fail DMARC checks, enhancing security
    against email spoofing.

    dns/autonomys-xyz.tf [53]

    -value   = "v=DMARC1; p=quarantine; rua=mailto:[email protected]; ruf=mailto:[email protected]; aspf=r; adkim=r;"
    +value   = "v=DMARC1; p=reject; rua=mailto:[email protected]; ruf=mailto:[email protected]; aspf=r; adkim=r;"
     
    Suggestion importance[1-10]: 9

    Why: Changing the DMARC policy to reject provides stricter handling of emails that fail DMARC checks, which significantly enhances email security against spoofing.

    9
    Enable proxying for applicable DNS records to enhance security

    Consider setting the proxied attribute to true for the DNS records where it is
    applicable. This can help protect the backend services from direct exposure on the
    internet, reducing potential security risks.

    dns/autonomys-xyz.tf [3]

    -proxied = false
    +proxied = true
     
    Suggestion importance[1-10]: 8

    Why: Enabling proxying can indeed enhance security by hiding the backend services from direct exposure on the internet. This is a significant improvement for security.

    8
    Performance
    Increase TTL for SPF and DKIM records to reduce DNS lookup frequency

    The TTL for the SPF and DKIM records is set to 1, which might be too low and can
    lead to frequent DNS lookups. Consider increasing the TTL to a higher value like
    3600 to reduce DNS lookup frequency and potential latency.

    dns/autonomys-xyz.tf [54-70]

    -ttl     = 1 # Auto
    +ttl     = 3600
     
    Suggestion importance[1-10]: 7

    Why: Increasing the TTL for SPF and DKIM records can reduce DNS lookup frequency and potential latency, which is a good performance optimization.

    7
    Best practice
    Add a trailing dot to the CNAME record value to ensure proper DNS resolution

    Ensure that the value for the CNAME record pointing to sites.framer.app is correctly
    configured to include a trailing dot if it is intended to be an absolute domain
    name, which is a common practice to avoid DNS resolution issues.

    dns/autonomys-xyz.tf [24]

    -value   = "sites.framer.app"
    +value   = "sites.framer.app."
     
    Suggestion importance[1-10]: 6

    Why: Adding a trailing dot to the CNAME record value is a best practice to ensure proper DNS resolution, though it is a minor improvement.

    6

    add autonomys.xyz and subspace.foundation records
    
    add spf,, dmarc records
    
    TTL fix
    
    remove proxying on safe cnames
    @DaMandal0rian DaMandal0rian merged commit c9b0b6d into main Sep 9, 2024
    1 check passed
    @DaMandal0rian DaMandal0rian deleted the dns-updates branch September 9, 2024 11:55
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    2 participants