Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SESv2 suppressed destination deletion and retrieval methods #1834

Merged
merged 1 commit into from
Jan 16, 2025
Merged

Add SESv2 suppressed destination deletion and retrieval methods #1834

merged 1 commit into from
Jan 16, 2025

Conversation

Seldaek
Copy link
Contributor

@Seldaek Seldaek commented Jan 15, 2025

No description provided.

@Seldaek Seldaek force-pushed the ses_suppressed_destination branch 2 times, most recently from 2720162 to d9b7a63 Compare January 15, 2025 15:07
Nyholm
Nyholm approved these changes Jan 15, 2025
View reviewed changes
Copy link
Member

@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

src/Service/Ses/tests/Unit/SesClientTest.php Outdated Show resolved Hide resolved
@Seldaek Seldaek force-pushed the ses_suppressed_destination branch from d9b7a63 to 2ac49be Compare January 15, 2025 15:09
Seldaek
Seldaek commented Jan 15, 2025
View reviewed changes
src/Service/Ses/CHANGELOG.md Outdated Show resolved Hide resolved
jderusse
jderusse approved these changes Jan 15, 2025
View reviewed changes
Copy link
Member

@jderusse jderusse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last failure is about changing the version in the src/Service/Ses/composer.json file (because it's a new feature that will be released in the next minor version, we need to bump

src/Service/Ses/CHANGELOG.md Outdated Show resolved Hide resolved
@Seldaek Seldaek force-pushed the ses_suppressed_destination branch from 2ac49be to bd313cc Compare January 15, 2025 16:10
@Seldaek
Copy link
Contributor Author

Seldaek commented Jan 15, 2025

Looks all good now

@jderusse jderusse merged commit 7d4bae5 into async-aws:master Jan 16, 2025
17 checks passed
@jderusse
Copy link
Member

Thank you @Seldaek

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nyholm Nyholm Nyholm approved these changes

@jderusse jderusse jderusse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Seldaek @jderusse @Nyholm