Add support for SSO authentication #1831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jderusse
force-pushed
the
sso-credential
branch
from
41fc3de to
fe93707
Compare
jderusse
force-pushed
the
sso-credential
branch
from
fe93707 to
a45ddbc
Compare
|
@jderusse I can try this out sometime in the new few hours. Thank you! |
|
@jderusse took me a couple of hours, and a sleep, to realize that I had a configuration bug when testing this. Now that I have resolved that, I am happy to report that this PR works perfectly. 🎉 |
Merged
stof
reviewed
Jan 15, 2025
|
|
||
| return $this->getCredentialsFromSsoSession($profilesData, $profileData, $profile); | ||
| } | ||
|
|
||
| if (isset($profileData[IniFileLoader::KEY_SSO_START_URL])) { | ||
| if (class_exists(SsoClient::class)) { |
There was a problem hiding this comment.
this change the branches without inverting the condition
| @@ -93,14 +93,24 @@ private function getCredentialsFromProfile(array $profilesData, string $profile, | |||
| return $this->getCredentialsFromRole($profilesData, $profileData, $profile, $circularCollector); | |||
| } | |||
|
|
|||
| if (isset($profileData[IniFileLoader::KEY_SSO_SESSION])) { | |||
| if (!class_exists(SsoClient::class)) { | |||
There was a problem hiding this comment.
shouldn't this check for SsoOidcClient instead ?
There was a problem hiding this comment.
already addressed by #1833
| 512, | ||
| \JSON_BIGINT_AS_STRING | (\PHP_VERSION_ID >= 70300 ? \JSON_THROW_ON_ERROR : 0) | ||
| ); | ||
| } catch (\JsonException $e) { |
There was a problem hiding this comment.
you also need the error handling for PHP 7.2 as it won't throw an error there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1581