This repository has been archived by the owner on Jul 14, 2022. It is now read-only.
Make the script work for modern (Fall 2017) activity page #19
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As this stands right now this should not be merged since the code can be cleaned up and made better. There's a lot of weird stuff from me figuring out Selenium and Facebook's activity page weirdness.
Basically the changes are:
WebElement.click()
function will literally emulate a mouse click at that coordinate rather than just triggering the action. This resulted in some weirdness with either the element being off-screen so it couldn't be clicked, the header getting in the way, or there not being enough room to show the full menu so Facebook wouldn't pop it. I ended up changing this logic so that instead I execute JavaScript to trigger theclick()
event which works a lot nicer but the old scroll logic remainsI wanted to make the PR for awareness though and can clean this up in a bit.
This change is