-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests for partitioning #156
base: pxf-6.x
Are you sure you want to change the base?
Conversation
Allure report https://allure.adsw.io/launch/91083 |
Allure report https://allure.adsw.io/launch/91241 |
Allure report https://allure.adsw.io/launch/91247 |
return new Object[][]{ | ||
{"oracle_ext_table", ORACLE}, | ||
{"mysql_ext_table", MYSQL}, | ||
{"postgres_ext_table", DEFAULT} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
perhaps is better to use corresponding name for Db, instead of default?
pxfLogFile = pxfHome + "/" + PXF_LOG_RELATIVE_PATH; | ||
} | ||
|
||
@Test(groups = {"arenadata"}, dataProvider = "useJdbcTimestampPartitioningProvider") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check if this test can / should be run within FDW suite as well. If yes, mark it with @WorksWithFDW annotation.
cluster.runCommandOnNodes(pxfNodes, "> " + pxfLogFile); | ||
} | ||
|
||
private void prepareSourceTable(JdbcDbType jdbcDbType) throws Exception { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add @step annotation
} | ||
} | ||
|
||
private ExternalTable createExternalTable(String pxfExternalTableName, String targetTableName, String pxfServerName) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add @step annotation
} | ||
} | ||
|
||
private void checkPxfLogs() throws Exception { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add @step annotation
No description provided.