ROVER-244 Remove dead code and tidy up #2352
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Docs preview has no changesThe preview was not built because there were no changes. Build ID: c88f02c0ed96b39e2e29f7f2 |
jonathanrainer
force-pushed
the
jr/task/ROVER-244
branch
from
7359587 to
d8f50a9
Compare
jonathanrainer
force-pushed
the
jr/task/ROVER-244
branch
from
d8f50a9 to
9ec7fc2
Compare
aaronArinder
approved these changes
Jan 15, 2025
Comment on lines
-15
to
-19
| #[cfg(not(feature = "dev-next"))] | ||
| pub mod legacy; | ||
| #[cfg(feature = "dev-next")] | ||
| pub mod next; | ||
|
|
There was a problem hiding this comment.
mind killing the github actions workflow boolean option too?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per title, now we're coming to the end of the refactor we can remove the code we're no longer using and tidy up our dependencies etc.