Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reuse ShardingSphereServiceLoader to instead of ElasticJobServiceLoader #2308

Merged
merged 17 commits into from
Oct 23, 2023

Conversation

terrymanu
Copy link
Member

No description provided.

@terrymanu terrymanu added this to the 3.1.0 milestone Oct 23, 2023
@codecov-commenter
Copy link

codecov-commenter commented Oct 23, 2023

Codecov Report

Merging #2308 (26c4620) into master (d213fba) will decrease coverage by 0.10%.
Report is 12 commits behind head on master.
The diff coverage is 73.68%.

@@             Coverage Diff              @@
##             master    #2308      +/-   ##
============================================
- Coverage     85.14%   85.04%   -0.10%     
+ Complexity     1239     1206      -33     
============================================
  Files           215      210       -5     
  Lines          3984     3926      -58     
  Branches        454      455       +1     
============================================
- Hits           3392     3339      -53     
+ Misses          386      385       -1     
+ Partials        206      202       -4     
Files Coverage Δ
...b/error/handler/general/IgnoreJobErrorHandler.java 100.00% <ø> (ø)
...ob/error/handler/general/ThrowJobErrorHandler.java 100.00% <ø> (ø)
...asticjob/executor/item/JobItemExecutorFactory.java 100.00% <ø> (ø)
...adpool/impl/CPUUsageJobExecutorServiceHandler.java 100.00% <100.00%> (ø)
.../elasticjob/infra/listener/ElasticJobListener.java 0.00% <ø> (ø)
...cjob/kernel/internal/sharding/ShardingService.java 97.72% <100.00%> (ø)
...cjob/error/handler/general/LogJobErrorHandler.java 83.33% <0.00%> (-16.67%) ⬇️
...sphere/elasticjob/executor/ElasticJobExecutor.java 86.81% <0.00%> (ø)
...e/elasticjob/executor/context/ExecutorContext.java 57.14% <83.33%> (-14.29%) ⬇️
...ob/infra/concurrent/ExecutorServiceReloadable.java 94.44% <88.88%> (+3.96%) ⬆️
... and 5 more

... and 4 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@RaigorJiang RaigorJiang merged commit b781c76 into apache:master Oct 23, 2023
12 checks passed
@terrymanu terrymanu deleted the dev branch October 24, 2023 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants