[Issue #7730] Add a RocketMQ BOM artifact #7732
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR is stale because it has been open for 365 days with no activity. It will be closed in 3 days if no further activity occurs. If you wish not to mark it as stale, please leave a comment in this PR. |
We move `rocketmq-all` to the `parent` subdirectory and update all relative paths in the children POMs.
Add a `rocketmq-bom` artifact that only manages RocketMQ dependency versions. The previous `rocketmq-all` artifact is reparented to `rocketmq-bom`.
ppkarwasz
force-pushed
the
rocketmq-bom
branch
from
b79e411 to
10cfe28
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #7732 +/- ##
=============================================
- Coverage 48.02% 47.97% -0.05%
+ Complexity 12050 12048 -2
=============================================
Files 1320 1320
Lines 92846 92846
Branches 11898 11898
=============================================
- Hits 44588 44545 -43
- Misses 42748 42789 +41
- Partials 5510 5512 +2 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Issue(s) This PR Fixes
Fixes #7730.
Brief Description
This PR implements the suggestion in Garret Wilson's blog on how to structure repositories containing a BOM artifact:
rocketmq-allPOM file is moved toparent/pom.xmland therelativePathattributes of all the other artifacts are updated,rocketmq-bomartifact is created as parent POM forrocketmq-all. It contains:rocketmq-*artifacts in this repo and alsorocketmq-proto,https://rocketmq.orgnothttps://rocketmq.org/rocketmq-all/rocketmq-common), all thechild.*.inherit.append.pathoptions have been set tofalse.How Did You Test This Change?
The change was tested with a
mvn verifystep and also by running:to check that the metadata of each artifact is correct.