[NIFI-13641] - Remove parameter value from parameter context update request if there are referenced assets #9173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rfellows
added
the
new ui
…equest if there are referenced assets
…ad construction rather than in the effect
rfellows
force-pushed
the
NIFI-13641-removeValueFromParamsWithReferencedAssets
branch
from
10c5219 to
f3ec180
Compare
|
Will review.... |
mcgilman
approved these changes
Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be merged along with #9138. When that allows adding of referenced assets to a parameter via the REST API the UI needs to be aware as to not overwrite this value if someone edits the parameter description from the UI.
NIFI-13641
If a parameter has referenced assets, the textual value (the path to the file) should be removed (if unchanged in the UI) before submitting it in an update request. This really only applies when a user might change the description of a parameter that has a referenced asset. However, if the user decides to change the value of the parameter in the UI, it should still respect that.