Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NIFI-13589] improve loading and error handling for jolt UI #9155

Merged
merged 4 commits into from
Aug 15, 2024

Conversation

scottyaslan
Copy link
Contributor

Kapture 2024-08-06 at 15 30 41

@scottyaslan scottyaslan added the new ui Pull requests for work relating to the new user interface being developed. label Aug 6, 2024
@rfellows
Copy link
Contributor

The snackbar error is a bit strange in this case. I think it would be better to just put it back to how it was before and show a full screen error since the page is not useable at all.

Copy link
Contributor

@rfellows rfellows left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @scottyaslan. Thanks for the update.

@rfellows rfellows merged commit 30e8df6 into apache:main Aug 15, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new ui Pull requests for work relating to the new user interface being developed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants