Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Windows launcher (2-6c17cc6) and move security manager flag from launcher to config #8122

Merged
merged 1 commit into from
Jan 13, 2025

Conversation

mbien
Copy link
Member

@mbien mbien commented Jan 7, 2025

this PR implements SM removal step 2 of 3

  1. remove SM flag from windows launcher and release new launcher bits
  2. move flag to config and switch to new launcher bits
  3. implement SM removal for JDK 24 compatibility

changes:

uses currently a staged build, vote needs to happen before merge

@mbien mbien added do not merge Don't merge this PR, it is not ready or just demonstration purposes. Platform [ci] enable platform tests (platform/*) ci:dev-build [ci] produce a dev-build zip artifact (7 days expiration, see link on workflow summary page) labels Jan 7, 2025
@mbien
Copy link
Member Author

mbien commented Jan 7, 2025

#6933 was the last PR which updated the launcher I used as template

@mbien mbien added this to the NB25 milestone Jan 7, 2025
@neilcsmith-net
Copy link
Member

neilcsmith-net commented Jan 7, 2025

Good for testing, but note that before vote this will need staging, alongside sources, at https://dist.apache.org/repos/dist/dev/netbeans/native/netbeans-launchers/2-6c17cc6/ including in this PR .. and it should be 2-6c17cc6. First number needs to be strictly incrementing, and also should match the number you incremented in the launcher build.

@mbien mbien changed the title Update to Windows launcher (1-6c17cc6) and move security manager flag from launcher to config Update to Windows launcher (2-6c17cc6) and move security manager flag from launcher to config Jan 7, 2025
@mbien mbien force-pushed the no-sm-win-launcher-update branch from fe7aecf to e3fd1fb Compare January 7, 2025 19:10
@mbien
Copy link
Member Author

mbien commented Jan 8, 2025

quick test with the dev-build artifact of this PR on windows:
image

NB launches fine on JDK 23 using the new launcher -> removing the flag from config causes launch failure -> flag is now set via config instead of win launcher -> works as intended

@mbien mbien force-pushed the no-sm-win-launcher-update branch from e3fd1fb to 969be01 Compare January 10, 2025 01:27
@mbien mbien added the Upgrade Library Library (Dependency) Upgrade label Jan 10, 2025
@mbien
Copy link
Member Author

mbien commented Jan 10, 2025

btw I think I will squash both commits before merge, since the flag move is one atomic change.

@mbien
Copy link
Member Author

mbien commented Jan 13, 2025

release is done, waiting for mirrors to sync so that I can push an update with the final link of the native launcher dependency so that we can integrate this + progress with step 3.

@mbien mbien removed the ci:dev-build [ci] produce a dev-build zip artifact (7 days expiration, see link on workflow summary page) label Jan 13, 2025
new native win launcher

 - doesn't set hardcoded '-Djava.security.manager=allow' anymore
 - minor update release

unix launcher script

 - move flag from launcher script to shared config file
 - flag can now be easily removed later
@mbien mbien force-pushed the no-sm-win-launcher-update branch from 969be01 to e390f33 Compare January 13, 2025 18:19
@mbien mbien removed the do not merge Don't merge this PR, it is not ready or just demonstration purposes. label Jan 13, 2025
@mbien mbien marked this pull request as ready for review January 13, 2025 18:20
@mbien
Copy link
Member Author

mbien commented Jan 13, 2025

this got already tested by some during vote, merging so that I can continue with #7928

@mbien mbien merged commit cb7da0c into apache:master Jan 13, 2025
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Platform [ci] enable platform tests (platform/*) Upgrade Library Library (Dependency) Upgrade
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants