-
Notifications
You must be signed in to change notification settings - Fork 867
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to Windows launcher (2-6c17cc6) and move security manager flag from launcher to config #8122
Conversation
#6933 was the last PR which updated the launcher I used as template |
Good for testing, but note that before vote this will need staging, alongside sources, at https://dist.apache.org/repos/dist/dev/netbeans/native/netbeans-launchers/2-6c17cc6/ including in this PR .. and it should be 2-6c17cc6. First number needs to be strictly incrementing, and also should match the number you incremented in the launcher build. |
fe7aecf
to
e3fd1fb
Compare
e3fd1fb
to
969be01
Compare
btw I think I will squash both commits before merge, since the flag move is one atomic change. |
release is done, waiting for mirrors to sync so that I can push an update with the final link of the native launcher dependency so that we can integrate this + progress with step 3. |
new native win launcher - doesn't set hardcoded '-Djava.security.manager=allow' anymore - minor update release unix launcher script - move flag from launcher script to shared config file - flag can now be easily removed later
969be01
to
e390f33
Compare
this got already tested by some during vote, merging so that I can continue with #7928 |
this PR implements SM removal step 2 of 3
changes:
uses currently a staged build, vote needs to happen before merge