[608] Ensure column stats for decimal fields have proper scale set #617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
the-other-tim-brown
force-pushed
the
608-decimal-stats-parsing
branch
from
5a5dccf to
509a81f
Compare
vinishjail97
reviewed
Jan 6, 2025
| @@ -242,18 +244,11 @@ private static Object castObjectToInternalType(Object value, InternalType valueT | |||
| return value; | |||
| } | |||
|
|
|||
| private static BigDecimal numberTypeToBigDecimal(Object value) { | |||
| private static BigDecimal numberTypeToBigDecimal(Object value, InternalSchema schema) { | |||
| // BigDecimal is parsed as Integer, Long, BigInteger and double if none of the above. | |||
There was a problem hiding this comment.
Do we still need this comment ?
// BigDecimal is parsed as Integer, Long, BigInteger and double if none of the above.
| int precision = (int) schema.getMetadata().get(InternalSchema.MetadataKey.DECIMAL_PRECISION); | ||
| int scale = (int) schema.getMetadata().get(InternalSchema.MetadataKey.DECIMAL_SCALE); | ||
| return new BigDecimal(String.valueOf(value), new MathContext(precision)) | ||
| .setScale(scale, RoundingMode.CEILING); |
There was a problem hiding this comment.
Should this be RoundingMode.HALF_UP by default ? Or any reason for choosing RoundingMode.CEILING ?
There was a problem hiding this comment.
I am going to switch this all to use UNNECESSARY where possible
| ? convertBytesToBigDecimal((ByteBuffer) maxValue, DECIMAL_WRAPPER_SCALE) | ||
| : maxValue; | ||
| ? convertBytesToBigDecimal((ByteBuffer) maxValue, scale) | ||
| : ((BigDecimal) maxValue).setScale(scale, RoundingMode.CEILING); |
There was a problem hiding this comment.
Same comment on choosing CEILING above HALF_UP for RoundingMode.
vinishjail97
approved these changes
Jan 7, 2025
the-other-tim-brown
force-pushed
the
608-decimal-stats-parsing
branch
from
cec320f to
c8a825f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important Read
What is the purpose of the pull request
Addresses bug found in #608
When converting the column stats to bytes in Iceberg, the
BigDecimal#unscaledValueis called. If the value has the wrong scale, then the serialization and then deserialization will result in a different value.Brief change log
Verify this pull request